Fix invalid data column sidecars getting accepted #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
changed the title
jimmygchen
added
bug
jimmygchen
added a commit
that referenced
this pull request
Oct 2, 2024
Squashed commit of the following: commit c935cc2 Author: Jimmy Chen <[email protected]> Date: Wed Oct 2 16:10:48 2024 +1000 Fix invalid data column sidecars getting accepted.
pawanjay176
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
LGTM.
Should we update the spec to explicitly not allow for sidecars with empty elements?
Edit: There's already a spec PR ethereum/consensus-specs#3953 . Maybe we duplicate the spec function in our code too to be consistent with the rest of the checks @jimmygchen ?
Yep good idea, done! |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 17849b5 |
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses #6440.
Data columns with empty cells were accepted because it's possible to generate a valid proof for an empty
kzg_commimentslist, therefore the invalid data columns was accepted and broke denvet-2 as clients react differently to this.This PR adds an additional validation for kzg commitment size.