Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base address for UNI #792

Merged
merged 5 commits into from
May 15, 2024
Merged

Base address for UNI #792

merged 5 commits into from
May 15, 2024

Conversation

jbarber13
Copy link
Contributor

@jbarber13 jbarber13 commented Apr 16, 2024 •
edited
Loading

Description

Add the UNI address to the token list for the Base bridge.

@jbarber13
IPT token added
5885ac7 
    * mkdir data/IPT and update data/IPT/data.json

    * update data/IPT/logo.svg

    Co-authored-by: Jake Barber <[email protected]>
@jbarber13
IPT token added
462fd4b 
        * update data/IPT/data.json

        Co-authored-by: Jake Barber <[email protected]>
@jbarber13
Merge branch 'ethereum-optimism:master' into master
daa325e
@jbarber13
Add UNI base token address
cb1a121 
Add USDT base token address
@jbarber13 jbarber13 requested a review from a team as a code owner April 16, 2024 21:33
@cfluke-cb
Copy link
Contributor

Hi @jbarber13 can we separate this into a PR for each token?
For the USDT token, can this be redeployed with the newest token factory? https://docs.base.org/docs/base-contracts#base-mainnet It currently looks like a copy of the OP version from 8/21

@jbarber13 jbarber13 changed the title Base address for UNI and USDT Base address for UNI Apr 17, 2024
@jbarber13
Copy link
Contributor Author

@cfluke-cb Hi,

I removed the USDT stuff from this PR, I'll make another one for USDT.

@jbarber13 jbarber13 mentioned this pull request Apr 17, 2024
Closed
cfluke-cb
cfluke-cb approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@cfluke-cb cfluke-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on Base side.

rcbgr
rcbgr reviewed Apr 25, 2024
View reviewed changes
Copy link

@rcbgr rcbgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your json is broken

@rcbgr rcbgr added the base label Apr 25, 2024
@jbarber13
Copy link
Contributor Author

your json is broken

@rcbgr
Can you elaborate on what is wrong with the JSON? It passes when I run the validation
image

@wbnns
Copy link
Member

wbnns commented Apr 27, 2024

@jbarber13

Heya, are you affiliated with Uniswap?

wbnns
wbnns requested changes Apr 27, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending confirmation that this is the canonical UNI.

@jbarber13
Copy link
Contributor Author

@wbnns

Heya, are you affiliated with Uniswap?

Hello,
I am with GFX Labs, we are a delegate for Uniswap.

@wbnns
Copy link
Member

wbnns commented May 1, 2024

@jbarber13

Thanks for confirming! We should hopefully have an update soon. We are also confirming via our channels with the Uniswap team that they would like this to be the canonical UNI on Base.

@wbnns wbnns self-assigned this May 3, 2024
@wbnns wbnns mentioned this pull request May 3, 2024
Closed
@wbnns
Copy link
Member

wbnns commented May 8, 2024

@jbarber13

Heya! Thanks for your patience, just wanted to follow-up! Can you link to any governance post alongside this deployment that would confirm it's approval?

@erin-koen
Copy link

Hey - gov lead from the uniswap foundation here (eek37 on the forum and on twitter). There is no gov post saying "the address of UNI on Base is 0x...". However, there is a post proposing to provide UNI-denominated liquidity incentives to L2 deployments of the protocol here. Base is one of those L2s, and UNI incentives are currently being provided via a Merlkl distributor contract on three pools (see deets here.

This proposal's author was Getty Hill who founded GFX. The proposal passed and GFX has helped to implement by, among other things deploying the token on various L2 chain including base ( https://basescan.org/token/0xc3de830ea07524a0761646a6a4e4be0e114a3c83#code).

Thanks

@wbnns
Copy link
Member

wbnns commented May 9, 2024

@erin-koen

Heya! Thanks for these details! We're reviewing and will follow-up asap. Appreciate all of the additional context. 🤝

wbnns
wbnns approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@mergify Mergify
Copy link
Contributor

mergify bot commented May 15, 2024

Merge failed. Please see automated check logs for more details.

@annieke annieke merged commit 9c0d0b3 into ethereum-optimism:master May 15, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcbgr rcbgr rcbgr left review comments

@cfluke-cb cfluke-cb cfluke-cb approved these changes

@annieke annieke annieke approved these changes

@wbnns wbnns wbnns approved these changes

Assignees

@wbnns wbnns

Labels
base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jbarber13 @cfluke-cb @wbnns @erin-koen @annieke @rcbgr