-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base l2 token address for UNI #803
Conversation
Add UNI - Uniswap - token address on Base L2.
Hi there! Thanks for the PR! Are you affiliated with Uniswap? |
Hey there @wbnns ! Always happy to contribute to the ETH ecosystem/Base in any way I can. My only affiliation in this capacity here is as a long-time user of the protocol. I noticed the OptimismStandardERC20 L2 token was deployed for UNI on Base, researched to confirm it does in fact map back to the proper address on L1, and figured it would be helpful for users/devs on Base to see the token if it is now live on Base. Let me know if there is anything else I could do to help grow Base. Weston |
hey @westonnelson, are you with Uniswap? If not, we are going to close this PR |
Also, your JSON is invalid. Please correct |
Greetings @rcbgr. No worries and sounds good. As I mentioned above, no: this PR is not in any affiliation with Uniswap here, I simply noticed the canonical token had been deployed on Base using the official bridge/canonical token bridge, and also that this L2 token is available for bridging using the Rollbridge app from Base to Ethereum and it was unclear to me why someone hadn't submitted the PR for this already. So I wanted to contribute here - apologies if this caused any confusion! Please let me know if I can help any further. Weston |
Thanks for the details! Checking into this and will follow-up here as soon as an update is available. 👍 |
Thanks for opening this PR! We're going to defer to #792 since it was opened first. |
Awesome, I'm always glad to help. If anything else is needed, please let me know. I just reviewed PR 792 you mentioned, looks good to me! Cheers 🫡 |
Description
Adding UNI - Uniswap - token address deployed on Base L2.
Additional context
Pinging @cfluke-cb @wbnns per PR instructions.