Avoid blank pages, omit desc tab instead #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, we could show the desc tab with a placeholder pointing to the Github repo (if available) |
Whatever suits you better. We can merge this as is and worry about that later, o make an extra push and resolve that. I'm happy with both! |
|
Thank you! |
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
These changes allow packages with Markdown (README) serialization failures to show up in the web hub instead of having a blank page. ATM the description tab is simply omitted if a serialization error occurs. Additionally, a log error is added so we can better track which packages fails at build time.
I also refactored some code to simplify stuff around the get static props by eliminating FP jargon. Moreover, if something brutal happens (eg. we get fetch the index) the entire build should fails to avoid deployment of a basically empty hub.
As a test, I took some packages listed in #43 and other discussions and check out locally that they show up in the web hub.
Here's some screenshots
This table arranges the four images in a 2x2 grid, with two images in each row.