Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html-colors package #130

Merged
merged 5 commits into from
Sep 8, 2024
Merged

Add html-colors package #130

merged 5 commits into from
Sep 8, 2024

Conversation

danielvartan
Copy link
Contributor

@danielvartan danielvartan commented Sep 4, 2024

Hi there,

I would like to contribute by adding a new package called html-colors to Espanso.

This package provides an easy way to insert HTML color codes directly into text. By typing shortcuts like ##red, the package automatically replaces them with their corresponding hex color codes (e.g., #FF0000). Additionally, it allows users to retrieve RGB color codes and color family information.

html-colors is designed to work seamlessly with the existing html-utils-package.

You can find more details about the package on its GitHub repository.

Thank you for considering this contribution. I appreciate your time and effort in maintaining Espanso!

Cheers! :)

Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A neat package of simple expansions with no shell, script or apparently malicious code.

Just a couple of things to consider.

packages/html-colors/0.1.0/package.yml Outdated Show resolved Hide resolved
packages/html-colors/0.1.0/README.md Outdated Show resolved Hide resolved
@smeech
Copy link
Collaborator

smeech commented Sep 5, 2024

Thank you. That appears good to go.

We've been having some problems with the Hub failing to construct details pages from the README.md files, so I'm consulting my colleague, @arabello, before we go ahead with the merge.

@arabello
Copy link

arabello commented Sep 8, 2024

espanso/hub-frontend#45 is merged, we can go ahead. I can't assure you ATM if your README will be included correctly, but the overall package page should be listed.

@smeech smeech merged commit e072bd1 into espanso:main Sep 8, 2024
1 check passed
@smeech
Copy link
Collaborator

smeech commented Sep 9, 2024

Done.

Merged successfully: https://hub.espanso.org/html-colors, but no "Description", so I guess the README.md didn't come across?

@arabello
Copy link

Correct

      Failed to serialize readme for package "[email protected]":
Error: [next-mdx-remote] error compiling MDX:
Unexpected character `!` (U+0021) before name, expected a character that can start a name, such as a letter, `$`, or `_` (note: to create a comment in MDX, use `{/* text */}`)

More information: https://mdxjs.com/docs/troubleshooting-mdx

@smeech
Copy link
Collaborator

smeech commented Sep 10, 2024

How odd!

@smeech
Copy link
Collaborator

smeech commented Oct 8, 2024

Without line numbers it's difficult to be confident about where the problem arises. I'm not sure of the reason for the exclamation marks at the beginning of a couple of early, non-displayed lines. Can these be removed, and would this solve the problem if we re-did the merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants