Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the scheduling won't start before everything is setup #324

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Oct 31, 2023

This fixes some obscure timing related problem that was first reliably discovered in #300 but I think I also have seen it on ESP32-C3's static-ip example (but there it magically disappeared)

This PR disables interrupts globally until all the interrupts are configured

I also found a way to reproduce the problem on current main (at the time of writing) on ESP32-C6:

  • in tasks.rs comment #[cfg(coex)]
  • in preemt/mod.rs make sure to allocate three stacks
  • run BLE example (or probably any other) with both, wifi and ble, enabled: cargo run --release --example ble --features=ble,wifi

(This supersedes #322)

@bjoernQ bjoernQ merged commit 8206445 into main Oct 31, 2023
14 checks passed
@bjoernQ bjoernQ deleted the fix-riscv-scheduler-start branch October 31, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants