Make sure systimer period is loaded and reset #322
Conversation
| let alarm0 = systimer.into_periodic(); | ||
| alarm0.set_period(TIMER_DELAY.into()); | ||
| // make sure the period is loaded and reset - should be done in esp-hal ultimately |
There was a problem hiding this comment.
How hard is the fix in esp-hal, why don't we try and fix it there before the next release?
There was a problem hiding this comment.
Probably because Jesse said the next release is today :D
There was a problem hiding this comment.
the fix would be trivial - just pull the code out of configure and call it there and in set_period .... but what Daniel said
I can create a PR in esp-hal and if it gets in that is fine and we remove it here - if not it will stay here a few weeks
There was a problem hiding this comment.
If we can get a PR merged in the next few hours then we can include it in today's releases. Otherwise will have to wait until next round.
|
Closing this and replacing it with #324 |
This fixes some obscure problem that was first reliably discovered in #300 but I think I also have seen it on ESP32-C3's static-ip example (but there it magically disappeared)
While I cannot really explain what is happening (I thought the problem was the scheduler starting to switch tasks while not all needed interrupts were enabled - which is not the problem) this seems to reliably eliminate the problem and is also an improvement generally
Turned out
alarm0.set_periodonly sets the period in systimer's registers but doesn't load them by writing totimer_compX_load.(Probably something that should be addressed ultimately in the HAL)
When a
yield_taskis executed, this means that the switched to task might not be given a full time-slice and also triggers the bug seen in the linked PR.This PR additionally disables interrupts globally until all the interrupts are configured (which on itself already would fix the problem)
I also found a way to reproduce the problem on current
main(at the time of writing):#[cfg(coex)]cargo run --release --example ble --features=ble,wifi