Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor specs to avoid expecting implementation #34

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Refactor specs to avoid expecting implementation #34

wants to merge 20 commits into from

Commits on Aug 11, 2022

  1. Add queue time buckets to configuration

    @Bodacious
    Bodacious committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    099255f View commit details
    Browse the repository at this point in the history

  2. Add class to calculate queue time duration

    @Bodacious
    Bodacious committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a399e87 View commit details
    Browse the repository at this point in the history

  3. Add request queue time to collector middleware

    @Bodacious
    Bodacious committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    2e6d53b View commit details
    Browse the repository at this point in the history

  4. Use a more generic string value for invalid header

    @Bodacious
    Bodacious authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e44f4bd View commit details
    Browse the repository at this point in the history

  5. Make queue time histogram name private

    @Bodacious
    Bodacious authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    97ca292 View commit details
    Browse the repository at this point in the history

  6. Remove unused constant

    @Bodacious
    Bodacious authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3dc843c View commit details
    Browse the repository at this point in the history

  7. Remove whitespace

    @Bodacious
    Bodacious authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    72b28cd View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Remove redundant double-bang operator

    @Bodacious
    Bodacious committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    8920a10 View commit details
    Browse the repository at this point in the history

  2. Reduce no. of default time duration buckets

    @Bodacious
    Bodacious committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    f36fa21 View commit details
    Browse the repository at this point in the history

  3. Extract queue time into separate middleware

    @Bodacious
    Bodacious committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    eef45e5 View commit details
    Browse the repository at this point in the history

  4. Remove unused constants from duration middleware

    @Bodacious
    Bodacious committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    4042925 View commit details
    Browse the repository at this point in the history

  5. Refactor private constant definition

    @Bodacious
    Bodacious committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    0f5f6cd View commit details
    Browse the repository at this point in the history

  6. Remove redundant requires from base class

    @Bodacious
    Bodacious committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    97bd84e View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Refactor specs to avoid expecting implementations

    @Bodacious
    Bodacious committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    5d61b11 View commit details
    Browse the repository at this point in the history

  2. Remove unused variable

    @Bodacious
    Bodacious committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    f445bb2 View commit details
    Browse the repository at this point in the history

  3. Make counter matcher private

    @Bodacious
    Bodacious authored Aug 15, 2022
    Configuration menu
    Copy the full SHA
    2ffc99a View commit details
    Browse the repository at this point in the history

  4. Refactor request duration middleware specs

    @Bodacious
    Bodacious committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    9977ad4 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Merge branch 'master' into gm/test-refactor

    @Bodacious
    Bodacious committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    968cdb4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gm/test-refactor' of github.com:errm/promenade into gm/… 

    …test-refactor
    @Bodacious
    Bodacious committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    928e0fa View commit details
    Browse the repository at this point in the history

  3. Fix Rubocop violation

    @Bodacious
    Bodacious committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    27518db View commit details
    Browse the repository at this point in the history