Refactor specs to avoid expecting implementation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodacious
commented
Aug 15, 2022
|
Moved back to draft. I think these changes are too much for one PR, and will split it into smaller parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor the test suite to avoid writing tests that rely on specific implementation details (e.g. method calls).
Why
We want the test suite for these objects to be as robust as possible. The previous implementation was testing that particualr methods were called, rather than testing expected outcomes.
How
Adds RSpec matchers to make better assertions on Prometheus metrics.
Refactor to use new metrics.
Use RSpec built-in helpers where appropriate.