Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sim_linelist() and sim_outbreak() snapshots #122

Merged
merged 1 commit into from
May 31, 2024

Conversation

joshwlambert
Copy link
Member

This PR updates the snapshots for the regression unit tests (testthat::expect_snapsnot()) that had started to fail because of an update to {epiparameter}.

This PR makes no functional changes to the {simulist} package.

Since epiverse-trace/epiparameter#323 the epidist_db() function preferentially selects database entries that account for right truncation when specifying single_epidist = TRUE. This impacts the unit tests of sim_linelist() and sim_outbreak() which call epiparameter::epidist_db() to load an onset-to-hospitalisation and an onset-to-death delay distribution. Since the change to {epiparameter} different delay distributions are being returned and as a result the simulated line lists and outbreak datasets are different to the previous snapshots.

@joshwlambert joshwlambert added the internal Updates that only change internal functions label May 31, 2024
@joshwlambert joshwlambert merged commit c80443e into main May 31, 2024
6 checks passed
@joshwlambert joshwlambert deleted the updt_snap_tests branch May 31, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Updates that only change internal functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant