Add structure to foi_index
across the package
#221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @ben18785 in #200, the way in which we were indexing the FOI was ambiguous as we were just providing a vector with the indexes (see #206):
rather than an structured object to specify the age/time indexation for estimating the FOI:
Now on, users will need to specify
foi_index
as a data.frame indexing either ages or years (as shown above) rather than as an unstructured list.get_foi_index()
may still be used for this end and its used the same as before with the caveat that the model type must be explicitly specified (e.g.):This PR also adds unit tests for
get_foi_index()
, addressing #220.