New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arsenal dependency and fix empty row index bug #173

Merged

Bisaloo merged 2 commits into main from rm-arsenal

Sep 2, 2024

Member

Bisaloo commented Aug 29, 2024 •

edited

Loading

Please check if the PR fulfills these requirements

I have read the CONTRIBUTING guidelines
A new item has been added to NEWS.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Checks have been run locally and pass


Remove arsenal dependency and fix empty row index bug

e6594c8

Bisaloo commented

View reviewed changes

tests/testthat/test-remove_constants.R Show resolved Hide resolved


Add NEWS bullet

1118a1d

Bisaloo force-pushed the rm-arsenal branch from d67bd08 to 1118a1d Compare

August 29, 2024 15:32

github-actions bot commented Aug 29, 2024

This pull request:

Adds 0 new dependencies (direct and indirect)
Adds 0 new system dependencies
Removes 1 existing dependencies (direct and indirect)
Removes 1 existing system dependencies

(Note that results may be inacurrate if you branched from an outdated version of the target branch.)

Karim-Mane approved these changes

View reviewed changes

Bisaloo merged commit a25e251 into main

9 checks passed

Bisaloo deleted the rm-arsenal branch

September 2, 2024 12:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment