Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 151 #157

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Fix issue 151 #157

wants to merge 22 commits into from

Commits on Aug 21, 2024

  1. update how the design diagram is inserted in the package design vignette

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a1cdf1a View commit details
    Browse the repository at this point in the history

  2. fix bug in scan_data() function

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    64b6dc1 View commit details
    Browse the repository at this point in the history

  3. fix bug in scan_data() function

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f069c59 View commit details
    Browse the repository at this point in the history

  4. Automatic readme update

    @actions-user @Karim-Mane
    actions-user authored and Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1df81b9 View commit details
    Browse the repository at this point in the history

  5. fix bug in scan_data() function

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    078514f View commit details
    Browse the repository at this point in the history

  6. account for other column types

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    26daa9e View commit details
    Browse the repository at this point in the history

  7. account for other column types

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5f2b59f View commit details
    Browse the repository at this point in the history

  8. refactor the scan_data() function

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ae5c490 View commit details
    Browse the repository at this point in the history

  9. refactor the scan_data() function

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    eb64d9f View commit details
    Browse the repository at this point in the history

  10. update the scan_date() function - only scan through character columns

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    17fee39 View commit details
    Browse the repository at this point in the history

  11. add/update rationale and documentation of the function

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3877253 View commit details
    Browse the repository at this point in the history

  12. account for hugo's suggestions

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bf533ab View commit details
    Browse the repository at this point in the history

  13. Update R/clean_data_helpers.R 

    Co-authored-by: Hugo Gruson <[email protected]>
    @Karim-Mane @Bisaloo
    Karim-Mane and Bisaloo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    6dbe40f View commit details
    Browse the repository at this point in the history

  14. update design vignette and function documentation: made when looking … 

    …for similar occurence of `six (06)`
    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    437a1be View commit details
    Browse the repository at this point in the history

  15. allow for double counting of numeric values as date when appropriate

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    46fb2ca View commit details
    Browse the repository at this point in the history

  16. add cli as a dependency

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1a4e139 View commit details
    Browse the repository at this point in the history

  17. update scan_data() internal functions

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1af8dd0 View commit details
    Browse the repository at this point in the history

  18. fix linters

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    356a143 View commit details
    Browse the repository at this point in the history

  19. remove the else statement

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a372271 View commit details
    Browse the repository at this point in the history

  20. update how oldest_date is calculated

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    fa1d9d7 View commit details
    Browse the repository at this point in the history

  21. update counting approach

    @Karim-Mane
    Karim-Mane committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0be056a View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. activate evaluation of remove_contants() code chunk

    @Karim-Mane
    Karim-Mane committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    939c9e1 View commit details
    Browse the repository at this point in the history