Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review #126

Merged
merged 59 commits into from
May 31, 2024
Merged

Review #126

merged 59 commits into from
May 31, 2024

Commits on Apr 5, 2024

  1. coerce id column into character

    @Karim-Mane
    Karim-Mane committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d87e0e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. rename some files and functions and use standardize

    @Karim-Mane
    Karim-Mane committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ed4c52c View commit details
    Browse the repository at this point in the history

  2. allow for using column names before column names standardisation is p… 

    …erformed
    @Karim-Mane
    Karim-Mane committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8e93416 View commit details
    Browse the repository at this point in the history

  3. Automatic readme update

    @actions-user
    actions-user committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    9ed144f View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. remove unnecesary line in DESCRIPTION file

    @Karim-Mane
    Karim-Mane committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a97c504 View commit details
    Browse the repository at this point in the history

  2. disable option for removing bad date sequences found by check_date_se… 

    …quence()
    @Karim-Mane
    Karim-Mane committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    207d829 View commit details
    Browse the repository at this point in the history

  3. disable possibility to provide a comma-separated list of column names.

    @Karim-Mane
    Karim-Mane committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a85ce72 View commit details
    Browse the repository at this point in the history

  4. remove the internal call of standardize_dates() from check_date_seque… 

    …nce()
    @Karim-Mane
    Karim-Mane committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    47821a3 View commit details
    Browse the repository at this point in the history

  5. use || instead of |

    @Karim-Mane
    Karim-Mane committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4e46588 View commit details
    Browse the repository at this point in the history

  6. optimize on the code in detect_to_numeric_columns() as suggested by Hugo

    @Karim-Mane
    Karim-Mane committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    0792230 View commit details
    Browse the repository at this point in the history

  7. use '.data$var' from rlang in some dplyr functions

    @Karim-Mane
    Karim-Mane committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    6dafba4 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. use regex to check prefix and suffix

    @Karim-Mane
    Karim-Mane committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f7595f8 View commit details
    Browse the repository at this point in the history

  2. allow for multiple prefix and suffix

    @Karim-Mane
    Karim-Mane committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5ad6e62 View commit details
    Browse the repository at this point in the history

  3. fix pkgdown issue

    @Karim-Mane
    Karim-Mane committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4c4aec9 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. create function to set the default cleaning operations.

    @Karim-Mane
    Karim-Mane committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    87eb266 View commit details
    Browse the repository at this point in the history

  2. update clean_data() documentation and account for the default cleanin… 

    …g arguments.
    @Karim-Mane
    Karim-Mane committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    36917e8 View commit details
    Browse the repository at this point in the history

  3. send warning the missing character is not found.

    @Karim-Mane
    Karim-Mane committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9f3f819 View commit details
    Browse the repository at this point in the history

  4. update documentation for standardize_dates() function

    @Karim-Mane
    Karim-Mane committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    05bd258 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. fine check params argument in clean_data() and fix linters

    @Karim-Mane
    Karim-Mane committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    84654b2 View commit details
    Browse the repository at this point in the history

  2. added new line to separate between messages and warning/errors

    @Karim-Mane
    Karim-Mane committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2b02dd3 View commit details
    Browse the repository at this point in the history

  3. allow for spelling check to run

    @Karim-Mane
    Karim-Mane committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b9bf764 View commit details
    Browse the repository at this point in the history

  4. document how the common_na_strings data was generated

    @Karim-Mane
    Karim-Mane committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a270623 View commit details
    Browse the repository at this point in the history

  5. fix typos in design vignette

    @Karim-Mane
    Karim-Mane committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    65c0d49 View commit details
    Browse the repository at this point in the history

  6. add the lang argument needed by convert_to_numeric()

    @Karim-Mane
    Karim-Mane committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e641dd2 View commit details
    Browse the repository at this point in the history

  7. use a vector for the rename argument in standardize_column_names()

    @Karim-Mane
    Karim-Mane committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    eac31c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. reduce else in scan_columns()

    @Karim-Mane
    Karim-Mane committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    23926f9 View commit details
    Browse the repository at this point in the history

  2. update the way the keep argument is handle in standardize_column_names()

    @Karim-Mane
    Karim-Mane committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    07f237a View commit details
    Browse the repository at this point in the history

  3. update replace_missing_values() with the usage of dplyr

    @Karim-Mane
    Karim-Mane committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b638d9a View commit details
    Browse the repository at this point in the history

  4. update add_to_report()

    @Karim-Mane
    Karim-Mane committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    eebe908 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. update the report printing function and Rmd files.

    @Karim-Mane
    Karim-Mane committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9691ca1 View commit details
    Browse the repository at this point in the history

  2. update vignette

    @Karim-Mane
    Karim-Mane committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f96668d View commit details
    Browse the repository at this point in the history

  3. oprimise on remove_constants() function

    @Karim-Mane
    Karim-Mane committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    16d6c2f View commit details
    Browse the repository at this point in the history

  4. add example on how lubridate::parse_date_time() works

    @Karim-Mane
    Karim-Mane committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    525b0c1 View commit details
    Browse the repository at this point in the history

  5. minor fix in to_numeric_convert() within convert_to_numeric.R

    @Karim-Mane
    Karim-Mane committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2313765 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. replace as_date() with lubridate::parse_date_time()

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    11d2386 View commit details
    Browse the repository at this point in the history

  2. update how column to be converted are looked for.

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    dfbbd5f View commit details
    Browse the repository at this point in the history

  3. make sure date that are out of range are properly reported

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0ce3a84 View commit details
    Browse the repository at this point in the history

  4. fix linters

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    46ace9b View commit details
    Browse the repository at this point in the history

  5. handle case where target_column is NULL within get_target_column_names()

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    32b90b3 View commit details
    Browse the repository at this point in the history

  6. remove {naniar} and {R.utils} as depencies

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6a88439 View commit details
    Browse the repository at this point in the history

  7. fix typos in function documentation

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0fd02c9 View commit details
    Browse the repository at this point in the history

  8. Use language="en-US" in DESCRIPTION file

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5a22f11 View commit details
    Browse the repository at this point in the history

  9. Use full name of the norm of the date format (ISO8601)

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    140ca6a View commit details
    Browse the repository at this point in the history

  10. remove test-clean.R

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6b6cbaa View commit details
    Browse the repository at this point in the history

  11. replace stringr::str_detect() by grepl()

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0473995 View commit details
    Browse the repository at this point in the history

  12. add Chris as reviewer

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    75fbec1 View commit details
    Browse the repository at this point in the history

  13. fix pkgdown-related issue

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ccf64b3 View commit details
    Browse the repository at this point in the history

  14. use {withr} to create tempdir when printing report

    @Karim-Mane
    Karim-Mane committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9a2bd8f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. suppress warning when performing dictionary-based cleaning

    @Karim-Mane
    Karim-Mane committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6c155a2 View commit details
    Browse the repository at this point in the history

  2. update vignettes

    @Karim-Mane
    Karim-Mane committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    4104a48 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. use paste()/paste0() instead of glue

    @Karim-Mane
    Karim-Mane committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    225ad05 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. add arbitrary to documentation of first_date argument in date_che… 

    …ck_timeframe() function
    @Karim-Mane
    Karim-Mane committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d64d09f View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. use {lubridate} functionalities to calculate time span and rename spa… 

    …n() into timespan()
    @Karim-Mane
    Karim-Mane committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1a448d1 View commit details
    Browse the repository at this point in the history

  2. use {lubridate} functionalities to calculate time span and rename spa… 

    …n() into timespan()
    @Karim-Mane
    Karim-Mane committed May 7, 2024
    Configuration menu
    Copy the full SHA
    aef8c53 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. make sure date_guess() also returns a dataframe with all possible for… 

    …mat for every date value.
    @Karim-Mane
    Karim-Mane committed May 8, 2024
    Configuration menu
    Copy the full SHA
    a7ec9d3 View commit details
    Browse the repository at this point in the history

  2. make sure date_guess() also returns a dataframe with all possible for… 

    …mat for every date value.
    @Karim-Mane
    Karim-Mane committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f9822b9 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. remove the remove parameter from the find_duplicates() function.

    @Karim-Mane
    Karim-Mane committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2f64748 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. update the DESCRIPTION file with funder and copyright information

    @Karim-Mane
    Karim-Mane committed May 27, 2024
    Configuration menu
    Copy the full SHA
    43a86ba View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. update the way columns are checked and their names matched with the o… 

    …riginal column names
    @Karim-Mane
    Karim-Mane committed May 29, 2024
    Configuration menu
    Copy the full SHA
    32447fb View commit details
    Browse the repository at this point in the history