tokenize_verilog: tokens can have a sign in general #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge or comment @lenerd |
|
What does a token actually represent (the naming is very generic), is it a wire id? |
Yes, it's a wire id, so it could be allowed to be negative. It doesn't hurt to parse it as an |
|
And these wire ids are not used as indices to an array anywhere? |
|
Commented there: encryptogroup/ABY#97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is used in ABY's
BooleanCircuit::PutGateFromFile. Tokens, in general, can have a sign so I propose to change the type of tokens toint. Will also shortly post a respective PR in the ABY repo.