Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PutGateFromFile: tokens are of type int in general #97

Open
wants to merge 2 commits into
base: public
Choose a base branch
from

Conversation

sebastianst
Copy link
Contributor

In general, .aby tokens can have a sign.
encryptogroup/ENCRYPTO_utils#13 has to be merged first.

This is dependent on ENCRYPTO_utils's tokenize_verilog making the same
change.
@dd23 dd23 force-pushed the public branch 4 times, most recently from 2b13460 to e7a5ddb Compare July 29, 2019 13:51
@sebastianst
Copy link
Contributor Author

Please comment @lenerd

@dd23
Copy link
Member

dd23 commented Apr 11, 2021

We kind of misused -2 and -3 to signal constant 0 and 1 in the circuits files here: https://github.com/encryptogroup/ABY/tree/public/bin/circ
See also https://github.com/encryptogroup/ABY/blob/public/bin/circ/circuitformat.md

Currently the negative numbers end up interpreted as unsigned ones, so e.g. as 4294967294. This is ugly, but worked so far, as long as no one loads files with 4294967294 or more wires...

If this change does not break the circuits (https://github.com/encryptogroup/ABY/tree/public/src/examples/float), we can merge it. Or we should check what else needs to be fixed, so we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants