-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate ItemsListInjection
mixin
#1460
Conversation
ItemsListInjection
mixin
packages/x-components/src/x-modules/next-queries/components/next-queries-list.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/next-queries/components/next-queries-list.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/next-queries/components/next-queries-list.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/search/components/promoteds-list.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/search/components/promoteds-list.vue
Outdated
Show resolved
Hide resolved
* @internal | ||
*/ | ||
( | ||
$x.on('RenderedColumnsNumberChanged', true) as unknown as Observable< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this subscription is only needed in this component and not the others? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/_vue3-migration-test/src/x-modules/search/components/index.ts
Outdated
Show resolved
Hide resolved
packages/_vue3-migration-test/src/x-modules/search/components/test-elements-list.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found why the NoElement was a problem in the playground. It has to do with how slots are working in vue 3 in contrast with vue 2. We can discuss it tomorrow!
Pull request template
Migrate
ItemsListInjection
mixin.The initial idea was to migrate all components that use this mixin and then remove it. The components involved are:
Motivation and context
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Tests performed according to testing guidelines:
Checklist: