refactor(noElement): use the full array of VNodes from the default slot #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegopf
changed the title
joseacabaneros
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
useNoElementRendercomposable to return the full VNodes array from the default slot, instead of just the first VNode. The former approach only works for Vue 2 where components can only have one single root node. However, Vue 3 allows having multiple root nodes for a component and it will break theNoElementusage.Thanks to the composition API is posible to use a render function that returns multiple VNodes via the return of the setup method. See declaring render functions
Once this PR is merged we could rollback some changes from #1460 and save the extra div that were needed here for
BannersList,ResultsList,PromotedsListandNextQueriesList