Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to rollup 4 #1370
feat: update to rollup 4 #1370
Changes from 14 commits
5fb60eb
dd70c30
513ffc4
eea0f4e
b1e41bf
7ecdac4
15bf52f
31b9c6e
4bc0267
6ace5bd
c146f65
e5061e7
702fd9a
b8bef3a
0615970
8d04713
47b0992
6cb920a
34e5917
65e95b3
036577f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to how rollup generates now the output filenames when preserving modules, we need to adjust the sideEffect field in the package.json so bundlers do not tree shake styles of vue components.
The rollup-plugin-vue splits every vue sfc into two virtual files. Taking for example the redirection.vue component:
redirection.vue?rollup-plugin-vue=script.ts
redirection.vue?rollup-plugin-vue=styles.0.css
Prior to v3 rollup generates three files:
redirection.vue.js
redirection.vue_rollup_plugin-vue_script.vue.js
redirection.vue_rollup_plugin-vue_styles.0.js.
However, now rollup will name those files:
redirection.vue.js
redirection.vue.2.js
redirection.vue.3.js
You can see a simple example using the rollup repl
Rollup 2.79.1 filenames
Rollup 4.9.1 filenames
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iep! We forgot this one!
output: [{ format: 'esm', dir: resolve(__dirname, '../showcase'), preserveModules: true }],