-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to rollup 4 #1370
Merged
Merged
feat: update to rollup 4 #1370
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5fb60eb
build: update to rollup 3
diegopf dd70c30
fix: `x-types` build
diegopf 513ffc4
bump plugins
diegopf eea0f4e
fix deprecation warning
diegopf b1e41bf
Merge branch 'main' into feat/update-rollup-versions
diegopf 7ecdac4
update pnpm-lock file
diegopf 15bf52f
refactor: rename sideEffects regex pattern
diegopf 31b9c6e
refactor: rename sideEffects regex pattern
diegopf 4bc0267
feat: remove unused plugin
diegopf 6ace5bd
feat: remove unused plugin
diegopf c146f65
undo unnecessary change
diegopf e5061e7
undo unnecessary change
diegopf 702fd9a
feat: update rollup to latest version
diegopf b8bef3a
chore: remove rollup from renovate restrictions
diegopf 0615970
move `@empathyco/x-utils` from devDeps to deps
diegopf 8d04713
set external deps
diegopf 47b0992
move `preserveModules` to output level
diegopf 6cb920a
fix typo
diegopf 34e5917
move `preserveModules` to output level
diegopf 65e95b3
Merge branch 'main' into feat/update-rollup-versions
annacv 036577f
update lockfile
annacv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 4 additions & 3 deletions
7
packages/x-tailwindcss/rollup.config.js → packages/x-tailwindcss/rollup.config.mjs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to how rollup generates now the output filenames when preserving modules, we need to adjust the sideEffect field in the package.json so bundlers do not tree shake styles of vue components.
The rollup-plugin-vue splits every vue sfc into two virtual files. Taking for example the redirection.vue component:
redirection.vue?rollup-plugin-vue=script.ts
redirection.vue?rollup-plugin-vue=styles.0.css
Prior to v3 rollup generates three files:
redirection.vue.js
redirection.vue_rollup_plugin-vue_script.vue.js
redirection.vue_rollup_plugin-vue_styles.0.js.
However, now rollup will name those files:
redirection.vue.js
redirection.vue.2.js
redirection.vue.3.js
You can see a simple example using the rollup repl
Rollup 2.79.1 filenames
Rollup 4.9.1 filenames