Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x-plugin): improve ResultFeature type values #1344

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix(x-plugin): improve ResultFeature type values #1344

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da530d6
fix(x-plugin): improve ResultFeature type values
herrardo Oct 30, 2023
feae086
feat: add new type with deprecated values
herrardo Oct 30, 2023
bf3ca3b
fix(x-plugin): export deprecated values to new type
herrardo Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/x-components/src/types/origin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,26 @@ export type QueryFeature =
| 'customer'
| 'semantics';

// TODO remove in major version. Deprecated value
/**
* @deprecated Use other features instead.
*/
type deprecatedFeatureNames = 'recommendations' | 'next_query_results' | 'semantics';

/**
* The name of the tool that generated the results.
*
* @public
*/
export type ResultFeature =
| 'search'
| 'recommendations'
| 'next_query_results'
| 'topclicked_recommendations'
| 'brand_recommendations'
| 'next_query_recommendations'
| 'semantic_recommendations'
| 'partial_results'
| 'identifier_result'
| 'brand_recommendations'
| 'semantics';
| deprecatedFeatureNames;

/**
* Indicates where the feature is placed.
Expand Down