Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x-plugin): improve ResultFeature type values #1344

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

herrardo
Copy link
Contributor

Pull request template

Add better name for ResultFeature values related to recommendations

Motivation and context

HAve a clear mapping of the features in the tagging

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-2689

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@herrardo herrardo requested a review from a team as a code owner October 30, 2023 09:55
@CachedaCodes CachedaCodes merged commit c4c9f6e into main Oct 31, 2023
4 checks passed
@CachedaCodes CachedaCodes deleted the fix/EMP-2689-improve-result-feature-types branch October 31, 2023 07:07
diegopf pushed a commit that referenced this pull request Nov 16, 2023
BREAKING CHANGE: remove deprecated origins from (#1344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants