feat(my-history): fix pr comments

empathyco · Nov 2, 2023 · b78ef52 · b78ef52
1 parent 6dfe40f
commit b78ef52
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 12 deletions.
diff --git a/src/components/history-query-filters.vue b/src/components/history-query-filters.vue
@@ -12,18 +12,16 @@
   </div>
 </template>
 
-<script>
-  import { defineComponent } from 'vue';
-  import { HistoryQuery } from '@empathyco/x-components/history-queries';
+<script lang="ts">
+  import { HistoryQuery } from '@empathyco/x-types';
+  import { defineComponent, PropType } from 'vue';
 
   export default defineComponent({
     props: {
       suggestion: {
-        type: HistoryQuery,
+        type: Object as PropType<HistoryQuery>,
         required: true
       }
     }
   });
 </script>
-
-<style scoped></style>
diff --git a/src/components/my-history/custom-my-history.vue b/src/components/my-history/custom-my-history.vue
@@ -24,7 +24,7 @@
             <div class="x-group x-flex x-flex-col x-gap-2">
               <p class="group-hover:x-underline">{{ suggestion.query }}</p>
 
-              <HistoryQueryFilters class="x-w-192" :suggestion="suggestion"></HistoryQueryFilters>
+              <HistoryQueryFilters class="x-w-224 desktop:x-w-320" :suggestion="suggestion" />
 
               <p class="x-text1 x-text1-sm x-text-neutral-75">
                 {{ formatTime(suggestion.timestamp) }}

diff --git a/src/components/predictive-layer/full-width-predictive.vue b/src/components/predictive-layer/full-width-predictive.vue
@@ -51,10 +51,7 @@
                                     :highlight="query"
                                     class="group-hover:x-underline"
                                   />
-                                  <HistoryQueryFilters
-                                    class="x-w-128"
-                                    :suggestion="suggestion"
-                                  ></HistoryQueryFilters>
+                                  <HistoryQueryFilters class="x-w-128" :suggestion="suggestion" />
                                 </div>
                               </template>
 

diff --git a/src/components/predictive-layer/predictive-layer.vue b/src/components/predictive-layer/predictive-layer.vue
@@ -56,7 +56,13 @@
                   >
                     <template #default="{ query }">
                       <HistoryIcon class="x-icon-lg desktop:x-icon-md" />
-                      <Highlight :text="suggestion.query" :highlight="query" />
+                      <div class="x-group x-flex x-flex-col x-gap-2">
+                        <Highlight :text="suggestion.query" :highlight="query" />
+                        <HistoryQueryFilters
+                          class="x-w-192 desktop:x-w-128"
+                          :suggestion="suggestion"
+                        />
+                      </div>
                     </template>
 
                     <template #remove-button-content>
@@ -129,6 +135,7 @@
   import { defineComponent } from 'vue';
   import { useDevice } from '../../composables/use-device.composable';
   import { usePredictiveHelpers } from '../../composables/use-predictive-helpers.composable';
+  import HistoryQueryFilters from '../history-query-filters.vue';
   import SlidingRecommendations from './sliding-recommendations.vue';
   import PredictiveIdentifierResults from './predictive-identifier-results.vue';
   import PredictiveQuerySuggestions from './predictive-query-suggestions.vue';
@@ -137,6 +144,7 @@
 
   export default defineComponent({
     components: {
+      HistoryQueryFilters,
       BaseScroll,
       PredictivePopularSearches,
       PredictiveNextQueries,