Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into feature/EMP-2293-Add-…
Browse files Browse the repository at this point in the history
…filters-in-my-history

# Conflicts:
#	package-lock.json
#	package.json
  • Loading branch information
lauramargar committed Nov 2, 2023
2 parents 9627342 + 77b6f1e commit 6dfe40f
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 14 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@empathyco/x-adapter": "^8.0.0-alpha.34",
"@empathyco/x-adapter-platform": "^1.0.0-alpha.88",
"@empathyco/x-archetype-utils": "^1.0.0-alpha.4",
"@empathyco/x-components": "^3.0.1-alpha.1",
"@empathyco/x-components": "^3.0.1-alpha.4",
"@empathyco/x-deep-merge": "^1.3.0-alpha.34",
"@empathyco/x-types": "^10.0.0-alpha.75",
"@empathyco/x-utils": "^1.0.0-alpha.23",
Expand Down
7 changes: 0 additions & 7 deletions src/adapter/adapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,6 @@ semanticQueriesRequestSchema.$override<
}
});

// TODO: Remove when the endpoint is propery created in the platform adapter
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
const experienceControlsAdapter = adapter.experienceControls.extends({
endpoint: 'https://config-service.internal.test.empathy.co/public/configs'
});
platformAdapter.experienceControls = experienceControlsAdapter;

// eslint-disable-next-line @typescript-eslint/no-unsafe-call
experienceControlsResponseSchema.$override<
PlatformExperienceControlsResponse,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<Recommendations class="x-flex x-flex-row x-gap-12 x-pl-16 desktop:x-pl-0">
<template #default="{ recommendation }">
<DisplayClickProvider resultFeature="recommendations">
<DisplayClickProvider resultFeature="topclicked_recommendations">
<Result
:result="recommendation"
data-test="recommendation-item"
Expand Down
2 changes: 1 addition & 1 deletion src/components/results/custom-recommendations.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</h1>
<Recommendations v-if="!$x.totalResults">
<template #layout="{ recommendations }">
<DisplayClickProvider resultFeature="recommendations">
<DisplayClickProvider resultFeature="topclicked_recommendations">
<BaseGrid
#default="{ item: result }"
:animation="staggeredFadeAndSlide"
Expand Down
2 changes: 1 addition & 1 deletion src/components/search/custom-semantic-queries.vue
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<ArrowRightIcon class="x-icon-lg" />
</SemanticQuery>
</template>
<DisplayClickProvider resultFeature="semantics">
<DisplayClickProvider resultFeature="semantic_recommendations">
<div class="x-flex x-gap-16 x-pt-16 max-desktop:x-px-16">
<Result
v-for="result in results.slice(0, resultsPerCarousel)"
Expand Down
8 changes: 6 additions & 2 deletions src/components/search/results/custom-next-query-preview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@
itemClass="x-flex-shrink-0"
>
<template #result="{ item: result }">
<Result :result="result" class="x-w-[calc(38vw-16px)] desktop:x-max-w-[265px]" />
<DisplayClickProvider resultFeature="next_query_recommendations">
<Result :result="result" class="x-w-[calc(38vw-16px)] desktop:x-max-w-[265px]" />
</DisplayClickProvider>
</template>
</ItemsList>
</CustomSlidingPanel>
Expand All @@ -42,6 +44,7 @@
import { useDevice } from '../../../composables/use-device.composable';
import Result from '../../results/result.vue';
import CustomSlidingPanel from '../../custom-sliding-panel.vue';
import DisplayClickProvider from '../display-click-provider.vue';
export default defineComponent({
components: {
Expand All @@ -50,7 +53,8 @@
Result,
ArrowRightIcon,
ItemsList,
NextQueryPreview
NextQueryPreview,
DisplayClickProvider
},
props: {
nextQuery: { type: Object as PropType<NextQueryModel>, required: true }
Expand Down

0 comments on commit 6dfe40f

Please sign in to comment.