Add some fixture utils ... #151
Conversation
NullVoxPopuli
force-pushed
the
add-fixture-utils
branch
from
e00c320
to
1a656f6
Compare
tests/utils.ts
Outdated
| scenario?: string; | ||
| } | ||
| ) { | ||
| let scenario = options?.scenario ?? 'default'; |
There was a problem hiding this comment.
I don't like that the default is the default value for scenario here, because it matters what folder you put the test file in. I feel like you could make this just a plain argument of the function and make it required, rather than part of the options and making it optional
There was a problem hiding this comment.
FWIW, I don't find default being the default too surprising 🙃
…d correctly for all tests, ensuring that the fixture utils work
… are ran from. ignore files do not cascade
NullVoxPopuli
force-pushed
the
add-fixture-utils
branch
from
d0df66d
to
4a82bb9
Compare
There was a problem hiding this comment.
Approved, with a minor suggestion, and also pointing to this related comment.
Btw, if people are concerned by introducing too much of our own testing infrastructure, we could also introduce chai-files, which is also used in the blueprint tests of ember-cli/ember-source IIRC, and which vitest can utilize. Not sure though if this will help much, as it's concerned about file assertions, not so much about generating fixtures...
tests/utils.ts
Outdated
|
|
||
| export const SUPPORTED_PACKAGE_MANAGERS = ['npm', 'yarn', 'pnpm'] as const; | ||
|
|
||
| export async function fixture( |
There was a problem hiding this comment.
I was not sure what this is doing when seeing it used in code, like generating a fixture, asserting against one, or reading it (which is happening here). Maybe rename to readFixture?
tests/utils.ts
Outdated
| scenario?: string; | ||
| } | ||
| ) { | ||
| let scenario = options?.scenario ?? 'default'; |
There was a problem hiding this comment.
FWIW, I don't find default being the default too surprising 🙃
…e fixtures / scenarios work
NullVoxPopuli
force-pushed
the
add-fixture-utils
branch
2 times, most recently
from
e524cc5
to
0e99425
Compare
…creation of addons will need to propagate through the existing tests but that can happen in other PRs
NullVoxPopuli
force-pushed
the
add-fixture-utils
branch
2 times, most recently
from
055732f
to
387847b
Compare
NullVoxPopuli
force-pushed
the
add-fixture-utils
branch
from
387847b
to
5d2aae9
Compare
and assert that the .prettierrc.js is generated correctly for all tests, ensuring that the fixture utils work
These are util needed for finishing #146
and #153
An example of using these utils can be seen here: #154