Add CI workflow to push dist output to separate branch #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2023
NullVoxPopuli
force-pushed
the
add-push-dist
branch
2 times, most recently
from
9daee8a
to
bd55162
Compare
NullVoxPopuli
force-pushed
the
add-fixture-utils
branch
3 times, most recently
from
387847b
to
5d2aae9
Compare
NullVoxPopuli
force-pushed
the
add-push-dist
branch
from
9cbd5bb
to
336df4a
Compare
NullVoxPopuli
force-pushed
the
add-push-dist
branch
from
336df4a
to
480eef7
Compare
simonihmig
approved these changes
Jul 19, 2023
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3<% if (pnpm) {%> | ||
| - uses: NullVoxPopuli/action-setup-pnpm@v2<%} else {%> |
There was a problem hiding this comment.
Why do we need the different setup for pnpm here? Is it worth the additional complexity here?
simonihmig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #143
Requires: #151
Because v2 addons need to be built,
we can't easily point package.json files at the git repo for easy cross-repo testing.
This push-dist workflow brings back that capability by placing the compiled assets on a "dist" branch
(configurable via the "branch" option)