Fix: Should not (evil-set-jump previous-pos) jump after evil-jump-forward #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2023
tomdl89
reviewed
Jun 9, 2023
|
@roxma thanks for the PR. As mentioned in the comment, I don't think you need to revert the renaming. |
|
Has there been any progress? I also have this problem. Whenever I jump back repeatedly, I can only jump forwards once. |
…ward
Steps to reproduce the issue:
- Create files `a` `b` `c` with the following content:
$ head a b c
==> a <==
b
I'm A
==> b <==
c
I'm B
==> c <==
I'm C
- Run `emancs a` to open bufer `a`
- Press `gf` to jump to bufer `b`
- Press `gf` to jump to bufer `c`
- Press `C-o` to jump back to bufer `b`
- Press `C-o` to jump back to bufer `a`
- Press `C-i` to jump foward to bufer `b`
- Press `C-i` to jump foward to bufer `c`, but the window stays with
buffer unexpectedly.
tomdl89
force-pushed
the
2303-multi-jump-forward
branch
3 times, most recently
from
557d115
to
d5d5152
Compare
tomdl89
force-pushed
the
2303-multi-jump-forward
branch
from
d5d5152
to
e3530b9
Compare
|
@dschrempf apologies for the delay. Now fixed in master. Please let me know if you observe otherwise. |
|
Wow, that was fast, thanks a lot! |
|
@tomdl89 Thank you for adding the tests. |
|
I can also confirm that this is working! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue:
abcwith the following content:emancs ato open buferagfto jump to buferbgfto jump to bufercC-oto jump back to buferbC-oto jump back to buferaC-ito jump foward to buferbC-ito jump foward to buferc, but the window stays on bufferbunexpectedly.