Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set :jump property to t for evil-edit #1770

Closed
wants to merge 1 commit into from

Conversation

roxma
Copy link
Contributor

@roxma roxma commented Mar 26, 2023

No description provided.

@axelf4
Copy link
Collaborator

axelf4 commented Apr 10, 2023

Since the Evil version of :edit already adds to the jump list when switching buffers, and

evil/evil-jumps.el

Lines 188 to 189 in de07e9a

(unless (and (equal first-pos current-pos)
(equal first-file-name file-name))
ensures that e.g. :e %<CR> does not add a jump even with this patch, I presume this PR only makes sense after #1771 is merged? Ideally the behavior should be changed to match :edit in Vim where it unconditionally adds a jump. Otherwise, I still think this is a good change, however a note could be added, as I got confused by the lack of noticeable change by this PR. Or am I missing something?

@roxma
Copy link
Contributor Author

roxma commented Apr 26, 2023

@axelf4

I'm sorry. I don't remember why I changed this. I'm closing this PR. I'll re-open if this change is found necessary.

Please help me reviewing PR #1772 . I believe it fixes an existing issue, which is described in the PR.

@roxma roxma closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants