Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display edited indicator for polls in the timeline #1897

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Display edited indicator for polls in the timeline.

Motivation and context

Screenshots / GIFs

Tests

  • Edit a poll
  • View the poll in the timeline

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

Copy link
Contributor

github-actions bot commented Nov 27, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4sD9MT

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4806a0) 67.72% compared to head (583131d) 64.82%.
Report is 157 commits behind head on develop.

❗ Current head 583131d differs from pull request most recent head e4e10cc. Consider uploading reports for the commit e4e10cc to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1897      +/-   ##
===========================================
- Coverage    67.72%   64.82%   -2.90%     
===========================================
  Files         1319     1308      -11     
  Lines        33357    33082     -275     
  Branches      7146     7088      -58     
===========================================
- Hits         22590    21445    -1145     
- Misses        7347     8311     +964     
+ Partials      3420     3326      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew marked this pull request as ready for review November 27, 2023 13:42
@jonnyandrew jonnyandrew requested a review from a team as a code owner November 27, 2023 13:42
@jonnyandrew jonnyandrew requested review from julioromano and removed request for a team November 27, 2023 13:42
Copy link

@julioromano julioromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me but I'd be happy if any other pair of eyes in @vector-im/element-android-reviewers look at this too.

@jonnyandrew jonnyandrew added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 27, 2023
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 27, 2023
@jonnyandrew jonnyandrew requested a review from a team November 28, 2023 13:27
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, look sane. Could be nice to have a preview with edited poll. Can be done later.

@bmarty
Copy link
Member

bmarty commented Dec 4, 2023

To merge if CI is happy.

@ganfra
Copy link
Member

ganfra commented Dec 4, 2023

I'll have a look as I take polls V2 work.

@ganfra ganfra self-assigned this Dec 4, 2023
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmarty
Copy link
Member

bmarty commented Dec 4, 2023

I'll have a look as I take polls V2 work.

OK, I let you merge it if you're happy with it.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 14, 2023
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 14, 2023
@ganfra ganfra merged commit 5d37c66 into develop Dec 14, 2023
16 checks passed
@ganfra ganfra deleted the jonny/timeline-poll-edited branch December 14, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants