[Story] Edit a poll

[alfogrillo]

Description

• As a poll creator
• I want to edit a poll
• So that I can amend polls quickly

Acceptance criteria

• Poll creators see the "edit poll" button in the timeline when no one voted yet
  • Alternatively users can use the timeline menu to edit a poll
• If someone voted, the "Edit poll" button becomes "End poll" an the edit isn't allowed anymore
  • In this case the timeline menu should't show the "Edit poll" option anymore
• After the edit starts, the apps shows a similar form as for the creation of a poll but with all the fields filled with the data from the editing poll (design).
• To complete the edit, the poll should pass all the preconditions we check for poll's creation (max 20 options, no empty options, no empty poll's question)
• After the tap on "Done", the new event (the edited poll) is sent in the timeline.
  • The editor is allowed to complete the edit even if votes arrive during the edit. Votes sent during the edit should be considered "lost" and the edited poll must not take them into account.
• Tap on "Cancel" shows this alert just if at least a change has been made in the form.
  • The same alert should be shown in the "create new poll" flow (copies need to updated).
• Tap on "Delete a Poll" will show a confirmation alert. If the action is confirmed, the poll is deleted from the timeline.
• Display the "(edited)" mark next to edited polls in the timeline

Size estimate

M

Dependencies

• [Tech] Rust SDK - Edit poll API #2180

Preconditions

• Editor must be the poll creator.
• Poll must have no votes cast

Sign-off

Android

• Design sign-off on completion
• QA sign-off on completion
• Product sign-off on completion

iOS

• Design sign-off on completion
• QA sign-off on completion
• Product sign-off on completion

Out of scope

• TBD

Open questions

• Can room's administrators (people having enough power levels) edit the poll as poll creators?
• What happens if votes are received while an a poll edit is in progress?
  • Legacy clients ignore the problem and allow the edit anyway. In this case the votes preceding the edit are not rendered in the timeline.
  • @VolkerJunginger suggests to disable the edit/raise an error when this happens
• Is local echo working for edited event? What happens on the timeline if the edit fails?

Subtasks

Android

Beta Give feedback

1. Allow editing a poll Allow polls to be edited element-x-android#1869
2. Add confirmation dialog for canceling an edit Confirm back navigation when editing a poll only if the poll was changed element-x-android#1886
3. Add delete button to edit poll screen Add option to delete a poll while editing the poll element-x-android#1895
4. Display the "(edited)" mark next to edited polls in the timeline Display edited indicator for polls in the timeline element-x-android#1897

iOS

Beta Give feedback

No tasks being tracked yet.

Other

Beta Give feedback

1. events: Allow replacement unstable poll start events to have no fallback ruma/ruma#1638
   +0
2. Clean up unused strings in Localazy (particularly for common dialogs which now differ between the platforms)