Generate React component for each icon #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
approved these changes
Jul 12, 2024
src/@types/index.d.ts
Outdated
Comment on lines
21
to
27
| declare module "prettier" { | ||
| export interface Options {} | ||
| } | ||
|
|
||
| declare module "svgo" { | ||
| export interface Config {} | ||
| } |
There was a problem hiding this comment.
This could do with a comment like that in global.d.ts
There was a problem hiding this comment.
Han, that's a leftover, I first tried there before moving things to global.d.ts
There was a problem hiding this comment.
Rebased and removed that
This should help with tree-shaking in downstream packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #89
This generates a proper React component for each icon.
This means that downstream packages can consume them directly without having to setup svgr locally.
The reason we want to do this is: