Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESM and upgrade dependencies #89

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

sandhose
Copy link
Member

This is the same as #82 which was closed because of GitHub oddities.

I would like to explore exporting icons as react components directly.
I noticed we were already exporting some JS, but with ESM syntax, and without type: module in the package.json.
So, I switched the whole package to ESM, which of course broke some stuff in the build process.

I fixed the build process, and then upgraded all the dev dependencies to the latest version.

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! My only concern would've been compatibility with Element Web for any future JS modules that we might export, because I know it to still be on CJS, but I see that you had no trouble generating CJS output in #90.

@sandhose sandhose merged commit 1d5881c into main Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants