Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit required_fields field for custom rules in UI [classic] #5287

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented May 30, 2024

Contributes to #5131.

Previews

  • Classic: Create a detection rule - There's a new step in every rule type procedure except for machine learning, which doesn't support the "required fields" feature.

  • Serverless: Click the link below, then navigate to the page above in the Serverless Security doc set.

Related

@joepeeples joepeeples added Team: Detections/Response Detections and Response Feature: Rules Docset: ESS Issues that apply to docs in the Stack release v8.15.0 labels May 30, 2024
@joepeeples joepeeples self-assigned this May 30, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small suggestion. 🚀

docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
@elasticdocs
Copy link

elasticdocs commented May 31, 2024

🚀 Built co-preview-docs successfully!

Issues? Visit #next-docs in Slack

@nikitaindik nikitaindik self-requested a review June 2, 2024 07:56
nikitaindik
nikitaindik previously approved these changes Jun 3, 2024
Copy link
Contributor

@nikitaindik nikitaindik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @joepeeples! Changes LGTM.

@elasticdocs
Copy link

elasticdocs commented Jul 3, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@joepeeples joepeeples merged commit ff8d574 into main Jul 3, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jul 3, 2024
* First draft: add step to rule procedures

* Edit step (both serverless & classic)

(cherry picked from commit ff8d574)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.mdx
joepeeples added a commit that referenced this pull request Jul 3, 2024
…ackport #5287) (#5506)

* Edit required_fields field for custom rules in UI [classic] (#5287)

* First draft: add step to rule procedures

* Edit step (both serverless & classic)

(cherry picked from commit ff8d574)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joepeeples joepeeples deleted the 5131-required-fields-classic branch July 3, 2024 20:58
@joepeeples joepeeples mentioned this pull request Aug 5, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Feature: Rules Team: Detections/Response Detections and Response v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants