Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit related_integrations field for custom rules in UI [classic] #5151

Merged
merged 8 commits into from
Jul 3, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented May 1, 2024

Important

Do not merge to main until after 8.14.0 release, maybe until 8.15 feature freeze. This is to avoid adding 8.15 features into previous versions' branches (since those branches would be cut from main).

Contributes to #5099 by adding a step for Related integrations in the rule creation docs.

Preview

Create a detection rule

Twin PR for serverless

Related

@joepeeples joepeeples added Team: Detections/Response Detections and Response Feature: Rules Docset: ESS Issues that apply to docs in the Stack release v8.15.0 labels May 1, 2024
@joepeeples joepeeples self-assigned this May 1, 2024
Copy link

github-actions bot commented May 1, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@joepeeples joepeeples requested review from maximpn and approksiu May 1, 2024 19:37
@joepeeples joepeeples marked this pull request as ready for review May 1, 2024 19:37
@joepeeples joepeeples requested a review from a team as a code owner May 1, 2024 19:37
@jpdjere jpdjere self-requested a review May 3, 2024 08:21
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small suggestions for your consideration, overall 🆒 🆒 🆒

@joepeeples
Copy link
Contributor Author

joepeeples commented May 8, 2024

This PR is ready to merge, but I don't think I should yet. If I merge now, then main will contain changes that won't be available in stateful until the 8.15 Stack release. Normally that's OK, since main always equals the next minor release. BUT if someone needs to update the same files with changes for 8.14 Stack release, they'll end up merging to main and then backporting to 8.14 and that's a problem, because the backport will bring this PR's 8.15 changes into the 8.14 branch.... I think? Or maybe not, if the backport is able to cherry-pick only the new changes intended for 8.14, not any and all diffs between main and 8.14...

joepeeples added a commit that referenced this pull request May 22, 2024
…337)

* Add new step to all rule types

* Revise step, use variable for URL

* Mention type-ahead

* Explain related integrations

Also links to more info, and moves that info to a more generic location (no longer just prebuilt)

* Apply changes from Ben's review

Review from #5151
@banderror banderror removed the request for review from jpdjere May 28, 2024 12:06
Copy link
Contributor

@approksiu approksiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joepeeples
Copy link
Contributor Author

We now have the 8.15 branch to backport into, so we're G2G.

@joepeeples joepeeples merged commit 50c3806 into main Jul 3, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Jul 3, 2024
* Add new step to all rule types

* Mention type-ahead

* Apply feedback from serverless twin PR

https://github.com/elastic/staging-serverless-security-docs/pull/337

* Apply changes from Ben's review

(cherry picked from commit 50c3806)
joepeeples added a commit that referenced this pull request Jul 3, 2024
…c] (backport #5151) (#5503)

* Edit related_integrations field for custom rules in UI [classic] (#5151)

* Add new step to all rule types

* Mention type-ahead

* Apply feedback from serverless twin PR

https://github.com/elastic/staging-serverless-security-docs/pull/337

* Apply changes from Ben's review

(cherry picked from commit 50c3806)

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joepeeples joepeeples deleted the 5099-related-integrations-edit-classic branch July 3, 2024 19:36
@joepeeples joepeeples mentioned this pull request Aug 5, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Feature: Rules Team: Detections/Response Detections and Response v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants