-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit related_integrations field for custom rules in UI [classic] #5151
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few small suggestions for your consideration, overall 🆒 🆒 🆒
This PR is ready to merge, but I don't think I should yet. If I merge now, then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We now have the 8.15 branch to backport into, so we're G2G. |
* Add new step to all rule types * Mention type-ahead * Apply feedback from serverless twin PR https://github.com/elastic/staging-serverless-security-docs/pull/337 * Apply changes from Ben's review (cherry picked from commit 50c3806)
…c] (backport #5151) (#5503) * Edit related_integrations field for custom rules in UI [classic] (#5151) * Add new step to all rule types * Mention type-ahead * Apply feedback from serverless twin PR https://github.com/elastic/staging-serverless-security-docs/pull/337 * Apply changes from Ben's review (cherry picked from commit 50c3806) * Delete docs/serverless directory and its contents --------- Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Important
Do not merge to
main
until after 8.14.0 release, maybe until 8.15 feature freeze. This is to avoid adding 8.15 features into previous versions' branches (since those branches would be cut frommain
).Contributes to #5099 by adding a step for Related integrations in the rule creation docs.
Preview
Create a detection rule
Twin PR for serverless
Related