Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES|QL tab added to Timeline #4065

Merged
merged 42 commits into from
Nov 6, 2023
Merged

ES|QL tab added to Timeline #4065

merged 42 commits into from
Nov 6, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Oct 17, 2023

Fixes #4025

Preview:

@github-actions
Copy link

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review October 24, 2023 18:07
Copy link

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great to me, thanks so much @nastasha-solomon !

@nastasha-solomon
Copy link
Contributor Author

@michaelolo24 some additional ES|QL docs were created this week, so I added some additional ES|QL resources and restructured some of the existing docs about ES|QL in Timeline. Can you take a look at this draft next week when you're back? Thanks!

@nastasha-solomon nastasha-solomon mentioned this pull request Nov 2, 2023
15 tasks
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few attribute comments; LGTM otherwise 😄

docs/events/timeline-ui-overview.asciidoc Outdated Show resolved Hide resolved
docs/events/timeline-ui-overview.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon merged commit 535a28c into main Nov 6, 2023
1 check passed
@nastasha-solomon nastasha-solomon deleted the issue-4025-esql-timeline branch November 6, 2023 20:12
mergify bot pushed a commit that referenced this pull request Nov 6, 2023
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Abdon Pijpelink <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
(cherry picked from commit 535a28c)
nastasha-solomon added a commit that referenced this pull request Nov 6, 2023
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Abdon Pijpelink <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
Co-authored-by: Nastasha Solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES|QL tab added to Timeline
5 participants