Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] [8.11.4 & 8.12][ESS] Remove mention of default query in the ES|QL tab docs #4578

Merged
merged 14 commits into from
Jan 10, 2024
Merged

[Request] [8.11.4 & 8.12][ESS] Remove mention of default query in the ES|QL tab docs #4578

merged 14 commits into from
Jan 10, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jan 5, 2024 •
edited
Loading

Fixes #4577

Preview:

@nastasha-solomon nastasha-solomon self-assigned this Jan 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nastasha-solomon nastasha-solomon changed the title [Request] [8.11.4 & 8.12] Remove mention of default query in the ES|QL tab docs [Request] [8.11.4 & 8.12][ESS] Remove mention of default query in the ES|QL tab docs Jan 8, 2024
@nastasha-solomon nastasha-solomon marked this pull request as ready for review January 8, 2024 20:21
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner January 8, 2024 20:21
PhilippeOberti
PhilippeOberti previously approved these changes Jan 8, 2024
View reviewed changes
Copy link

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, it's clear, concise and you mention the error rendered on the empty query!

michaelolo24
michaelolo24 previously approved these changes Jan 9, 2024
View reviewed changes
Copy link

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

benironside
benironside previously approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a couple minor suggestions

@nastasha-solomon @benironside
Update docs/events/timeline-ui-overview.asciidoc
a510e9b 
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
@nastasha-solomon nastasha-solomon requested a review from a team January 10, 2024 20:52
@nastasha-solomon nastasha-solomon merged commit 8332e3f into main Jan 10, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@nastasha-solomon @mergify
[Request] [8.11.4 & 8.12][ESS] Remove mention of default query in the…
d61bf08 
… ES|QL tab docs (#4578)

* First draft

* Small edits

* Minor tweaks

* Update docs/events/timeline-ui-overview.asciidoc

* Potential revision

* Wording

* Update docs/events/timeline-ui-overview.asciidoc

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Update docs/events/timeline-ui-overview.asciidoc

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 8332e3f)
@mergify mergify bot mentioned this pull request Jan 10, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@nastasha-solomon @mergify
[Request] [8.11.4 & 8.12][ESS] Remove mention of default query in the…
df2dbac 
… ES|QL tab docs (#4578)

* First draft

* Small edits

* Minor tweaks

* Update docs/events/timeline-ui-overview.asciidoc

* Potential revision

* Wording

* Update docs/events/timeline-ui-overview.asciidoc

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Update docs/events/timeline-ui-overview.asciidoc

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 8332e3f)
@mergify mergify bot mentioned this pull request Jan 10, 2024
Merged
nastasha-solomon added a commit that referenced this pull request Jan 11, 2024
@mergify @nastasha-solomon
[8.11] [Request] [8.11.4 & 8.12][ESS] Remove mention of default query…
2198db6 
… in the ES|QL tab docs (backport #4578) (#4595)

* First draft

* Small edits

* Minor tweaks

* Update docs/events/timeline-ui-overview.asciidoc

* Potential revision

* Wording

* Update docs/events/timeline-ui-overview.asciidoc

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Update docs/events/timeline-ui-overview.asciidoc

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 8332e3f)

Co-authored-by: Nastasha Solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Jan 11, 2024
@mergify @nastasha-solomon
[8.12] [Request] [8.11.4 & 8.12][ESS] Remove mention of default query…
6e5ed98 
… in the ES|QL tab docs (backport #4578) (#4594)

* First draft

* Small edits

* Minor tweaks

* Update docs/events/timeline-ui-overview.asciidoc

* Potential revision

* Wording

* Update docs/events/timeline-ui-overview.asciidoc

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Update docs/events/timeline-ui-overview.asciidoc

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 8332e3f)

Co-authored-by: Nastasha Solomon <[email protected]>
@nastasha-solomon nastasha-solomon deleted the issue-4577-esql-default-query branch January 11, 2024 14:01
@nastasha-solomon nastasha-solomon mentioned this pull request Jan 12, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 left review comments

@benironside benironside benironside approved these changes

@PhilippeOberti PhilippeOberti Awaiting requested review from PhilippeOberti

Assignees

@nastasha-solomon nastasha-solomon

Labels
Feature: Timeline Team: Threat Hunting Formerly Data Visibility v8.11.0 v8.11.4 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] [8.11.4 & 8.12] Remove mention of default query in the ES|QL tab docs
4 participants
@nastasha-solomon @michaelolo24 @PhilippeOberti @benironside