Skip to content

Commit

Permalink
ci: Fix lint errors due to mypy with python 3.12 (#1890)
Browse files Browse the repository at this point in the history
* ci: Fix lint errors.

Now that we're using python 3.12 for the `lint` github action, we need
to fix the errors that it is reporting.

* fix: Pin `aiohttp` to fix lint error

Also reorganize the transitive dependencies in pyproject.toml

* fix: downgrade aiohttp because of python 3.8 support

* fix: Add `type: ignore` back, until we drop support for python 3.8

* Pin at 3.10.11 instead of 3.10.8

* Remove ignore again

---------

Co-authored-by: Grzegorz Banasiak <[email protected]>
  • Loading branch information
favilo and gbanasiak authored Nov 18, 2024
1 parent 348a0e9 commit 65ec3bd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion esrally/client/asynchronous.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ async def send(self, conn: "Connection") -> "ClientResponse":
self.response = self.response_class(
self.method,
self.original_url,
writer=self._writer, # type: ignore[arg-type] # TODO remove this ignore when introducing type hints
writer=self._writer,
continue100=self._continue,
timer=self._timer,
request_info=self.request_info,
Expand Down
7 changes: 3 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,12 @@ classifiers = [
################################################################################################
dependencies = [
# License: Apache 2.0
# transitive dependencies:
# urllib3: MIT
# aiohttp: Apache 2.0

"elasticsearch[async]==8.6.1",
"elastic-transport==8.4.1",
# License: MIT
"urllib3==1.26.19",
# License: Apache 2.0
"aiohttp==3.10.11",
"docker==6.0.0",
# avoid specific requests version to fix bug in docker-py
"requests<2.32.0",
Expand Down

0 comments on commit 65ec3bd

Please sign in to comment.