Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(apm): remove old rum deprecations #4644

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Dec 9, 2024

Description

deprecated rum config options have been removed in 8.0 so they no longer apply.
remove the deprecated options from docs

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes elastic/apm-server#14126

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs
@kruskall kruskall added backport-8.9 Automated backport with mergify backport-8.1 Automated backport with mergify backport-8.2 Automated backport with mergify backport-8.0 Automated backport with mergify backport-8.4 Automated backport with mergify backport-8.5 Automated backport with mergify backport-8.6 Automated backport with mergify backport-8.7 Automated backport with mergify backport-8.8 Automated backport with mergify backport-8.3 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Dec 9, 2024
@kruskall kruskall requested a review from a team as a code owner December 9, 2024 15:24
Copy link
Contributor

github-actions bot commented Dec 9, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis
Copy link
Contributor

@kruskall how important is it to backport all the way to 8.0? In 8.12 we moved the APM guide content from apm-server / APM guide to observability-docs / Observability guide. We would have to open separate PRs for 8.0-8.11 if those need to be updated. (I can do this, but I wanted to check before I spent too much time on it!)

@kruskall
Copy link
Member Author

kruskall commented Dec 9, 2024

I'd say 8.12+ should be enough IMO

cc @simitt for confirmation

@colleenmcginnis
Copy link
Contributor

I'll take the other backports off this PR, and I can address them separately if needed.

@colleenmcginnis colleenmcginnis removed backport-8.9 Automated backport with mergify backport-8.1 Automated backport with mergify backport-8.2 Automated backport with mergify labels Dec 9, 2024
@colleenmcginnis colleenmcginnis removed backport-8.3 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify labels Dec 9, 2024
@kruskall
Copy link
Member Author

@colleenmcginnis sorry for the ping, should I go ahead and merge this ?

@colleenmcginnis
Copy link
Contributor

@kruskall yes you can merge any time! I can keep an eye on the backports and fix any conflicts.

@kruskall kruskall merged commit 944662f into elastic:main Dec 12, 2024
65 checks passed
@kruskall kruskall deleted the docs/remove-deprecation branch December 12, 2024 14:57
@kruskall
Copy link
Member Author

thanks 🙇

mergify bot pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

# Conflicts:
#	docs/en/observability/apm/configure/rum.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

# Conflicts:
#	docs/en/observability/apm/configure/rum.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

# Conflicts:
#	docs/en/observability/apm/configure/rum.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

# Conflicts:
#	docs/en/observability/apm/configure/rum.asciidoc
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)
colleenmcginnis pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

Co-authored-by: kruskall <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

Co-authored-by: kruskall <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Dec 12, 2024
deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

Co-authored-by: kruskall <[email protected]>
colleenmcginnis added a commit that referenced this pull request Dec 12, 2024
* cleanup(apm): remove old rum deprecations (#4644)

deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

# Conflicts:
#	docs/en/observability/apm/configure/rum.asciidoc

* fix conflict

* adjust heading level

---------

Co-authored-by: kruskall <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis added a commit that referenced this pull request Dec 12, 2024
* cleanup(apm): remove old rum deprecations (#4644)

deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

# Conflicts:
#	docs/en/observability/apm/configure/rum.asciidoc

* fix conflict

---------

Co-authored-by: kruskall <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis added a commit that referenced this pull request Dec 12, 2024
* cleanup(apm): remove old rum deprecations (#4644)

deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

# Conflicts:
#	docs/en/observability/apm/configure/rum.asciidoc

* fix conflict

---------

Co-authored-by: kruskall <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis added a commit that referenced this pull request Dec 12, 2024
* cleanup(apm): remove old rum deprecations (#4644)

deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

# Conflicts:
#	docs/en/observability/apm/configure/rum.asciidoc

* fix conflict

* fix link

---------

Co-authored-by: kruskall <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated config options for RUM
2 participants