Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting/Docs: Updates for setting to enable CSV Download #78101

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Reporting/Docs: Updates for setting to enable CSV Download #78101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bda265d
Reporting/Docs - update documentation about setting to enable CSV Dow…
tsullivan Sep 22, 2020
7f55233
Merge branch 'master' into reporting/csv-docs-update
tsullivan Sep 22, 2020
9a3ae8a
break up long setting name to fix table scrolling
tsullivan Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/settings/reporting-settings.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,10 @@ a| `xpack.reporting.capture.browser`
See OWASP: https://www.owasp.org/index.php/CSV_Injection
Defaults to `true`.

| `xpack.reporting.csv.enablePanelActionDownload`
| Enables CSV export from a saved search on a dashboard. This action is available in the dashboard
panel menu for the saved search.
Defaults to `true`.
| `xpack.reporting.csv` `.enablePanelActionDownload`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchaps would you mind taking a look at this change? I added a space character in the label of the setting so that the line can wrap and the table cell would not be forced to be too wide.

This is in regards to the screenshot, where you can see a horizontal scrollbar in the table of CSV settings (taken in Chrome).

| Enables CSV export from a saved search on a dashboard. This action is available in the dashboard panel menu for the saved search.
*Note:* This setting exists for backwards compatibility, but is unused and hardcoded to `true`. CSV export from a saved search on a dashboard
is enabled when Reporting is enabled.

|===

Expand Down
Loading