Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting/Docs: Updates for setting to enable CSV Download #78101

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Sep 22, 2020

Summary

Closes #76894

This PR updates the Reporting Settings documentation to show that xpack.reporting.csv.enablePanelActionDownload is unused and being deprecated (exists for BWC).

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Sep 22, 2020
@gchaps
Copy link
Contributor

gchaps commented Sep 22, 2020

@elasticmachine, run elasticsearch-ci/docs

@ppf2
Copy link
Member

ppf2 commented Sep 22, 2020

LGTM, thx!

| Enables CSV export from a saved search on a dashboard. This action is available in the dashboard
panel menu for the saved search.
Defaults to `true`.
| `xpack.reporting.csv` `.enablePanelActionDownload`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchaps would you mind taking a look at this change? I added a space character in the label of the setting so that the line can wrap and the table cell would not be forced to be too wide.

This is in regards to the screenshot, where you can see a horizontal scrollbar in the table of CSV settings (taken in Chrome).

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsullivan tsullivan merged commit 0f8bbf1 into elastic:master Sep 22, 2020
@tsullivan tsullivan deleted the reporting/csv-docs-update branch September 22, 2020 21:13
tsullivan added a commit to tsullivan/kibana that referenced this pull request Sep 22, 2020
…8101)

* Reporting/Docs - update documentation about setting to enable CSV Download

* break up long setting name to fix table scrolling
tsullivan added a commit to tsullivan/kibana that referenced this pull request Sep 22, 2020
…8101)

* Reporting/Docs - update documentation about setting to enable CSV Download

* break up long setting name to fix table scrolling
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 23, 2020
* master: (31 commits)
  skip tests for old pacakge (elastic#78194)
  [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872)
  [Lens] Rename "telemetry" to "stats" (elastic#78125)
  [CSM] Url search (elastic#77516)
  [Drilldowns] Config to disable URL Drilldown  (elastic#77887)
  [Lens] Combined histogram/range aggregation for numbers (elastic#76121)
  Remove legacy plugins support (elastic#77599)
  'Auto' interval must be correctly calculated for natural numbers (elastic#77995)
  [CSM] fix ingest data retry order messed up (elastic#78163)
  Add response status helpers (elastic#78006)
  Bump react-beautiful-dnd (elastic#78028)
  [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004)
  Index pattern  - refactor constructor (elastic#77791)
  Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192)
  Remove [key: string]: any; from IIndexPattern (elastic#77968)
  Remove requirement for manage_index_templates privilege for Index Management (elastic#77377)
  [Ingest Manager] Agent bulk actions UI (elastic#77690)
  [Metrics UI] Add inventory view timeline (elastic#77804)
  Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101)
  Update to latest rum-react (elastic#78193)
  ...
tsullivan added a commit that referenced this pull request Sep 23, 2020
…78217)

* Reporting/Docs - update documentation about setting to enable CSV Download

* break up long setting name to fix table scrolling
tsullivan added a commit that referenced this pull request Sep 23, 2020
…78218)

* Reporting/Docs - update documentation about setting to enable CSV Download

* break up long setting name to fix table scrolling
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead docs release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document xpack.reporting.csv.enablePanelActionDownload as experimental
5 participants