[Dashboard] EUI Visual Refresh Integration #204442
Merged
+45
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
force-pushed
the
borealis/dashboard/replace-euiThemeVars-usage
branch
from
a63e9e5 to
fd9b122
Compare
cqliu1
added
Feature:Dashboard
cqliu1
force-pushed
the
borealis/dashboard/replace-euiThemeVars-usage
branch
from
bb1f68c to
bddbc7d
Compare
cqliu1
force-pushed
the
borealis/dashboard/replace-euiThemeVars-usage
branch
from
bddbc7d to
6d69138
Compare
9 tasks
mgadewoll
reviewed
Dec 17, 2024
.../presentation_panel/public/panel_component/panel_header/presentation_panel_hover_actions.tsx
Outdated
Show resolved
Hide resolved
| @@ -142,11 +147,11 @@ export const PresentationPanelHoverActions = ({ | |||
| const hoverActionsWidth = | |||
| (rightHoverActionsRef.current?.offsetWidth ?? 0) + | |||
| (dragHandleRef.current?.offsetWidth ?? 0) + | |||
| parseInt(euiThemeVars.euiSize, 10) * 2; | |||
| parseInt(euiTheme.size.m, 10) * 2; | |||
There was a problem hiding this comment.
This should probably be euiTheme.size.base as euiSize was 16px and euiTheme.size.m is 12px
(same for the following occurrences)
.../presentation_panel/public/panel_component/panel_header/presentation_panel_hover_actions.tsx
Outdated
Show resolved
Hide resolved
| position: absolute; | ||
| top: 0; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| padding: 0 ${euiThemeVars.euiSize}; | ||
| padding: 0 ${euiTheme.size.medium}; |
There was a problem hiding this comment.
Blocking euiTheme.size.medium does not exists. Based on the original value, this likely should be euiTheme.size.base.
cqliu1
changed the title
cqliu1
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
cqliu1
added
backport:version
nreese
reviewed
Dec 17, 2024
|
|
||
| const { euiTheme } = useEuiTheme(); | ||
|
|
||
| const EDIT_MODE_OUTLINE = `${euiTheme.border.width.thin} dashed ${euiTheme.colors.borderBaseFormsControl}`; |
There was a problem hiding this comment.
Can you use useMemo to avoid recreating these string on each render.
There was a problem hiding this comment.
I think useMemo usage is best left to things which are expensive to compute. useMemo itself can introduce overhead .
…://github.com/cqliu1/kibana into borealis/dashboard/replace-euiThemeVars-usage
mgadewoll
approved these changes
Dec 18, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
Page load bundle
History
|
nreese
approved these changes
Dec 18, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #203132.
Part of #204590.
This replaces all references to euiThemeVars in favor of the useEuiTheme hook in the dashboard plugin. This also updates the color of the presentational panel border in edit mode from
mediumShade, which was deprecated, toBorderBaseFormsControlas the darker border color.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.