Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] EUI Visual Refresh Integration and QA #204590

Open
5 of 10 tasks
cqliu1 opened this issue Dec 17, 2024 · 1 comment
Open
5 of 10 tasks

[Dashboard] EUI Visual Refresh Integration and QA #204590

cqliu1 opened this issue Dec 17, 2024 · 1 comment
Assignees
Labels
Feature:Dashboard Dashboard related features impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Dec 17, 2024

Related to #203132.

This issue is for tracking work that needs to be done for the EUI Visual Refresh for the Dashboard plugins specifically.

Checklist

Known Bugs

  • presentation panel border colors are too light, mediumShade color was deprecated
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 17, 2024
@cqliu1 cqliu1 added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Dec 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 17, 2024
@cqliu1 cqliu1 added Feature:Dashboard Dashboard related features loe:medium Medium Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Dec 17, 2024
@cqliu1 cqliu1 self-assigned this Dec 18, 2024
@cqliu1 cqliu1 closed this as completed in 4a6e1e5 Dec 18, 2024
@andreadelrio andreadelrio reopened this Dec 19, 2024
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
## Summary

Related to elastic#203132.
Closes elastic#204590.

This replaces all references to euiThemeVars in favor of the useEuiTheme
hook in the dashboard plugin. This also updates

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants