[ResponseOps][Connectors]Migrate remaining routes. #204042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
reviewed
Dec 13, 2024
There was a problem hiding this comment.
I think we should not provide the same reason for all routes as both the stack connectors and the triggers actions UI do not use their authorization model. Specifically:
For the stack connectors:
- Inference API relies on ES authorization.
- Email service does not perform any authorization.
- Slack API relies on Slack's authorization.
For triggers actions UI:
- Config relies on the alerting authorization
-Health service does not perform any authorization
cnasikas
approved these changes
Dec 13, 2024
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @adcoelho |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
adcoelho
added a commit
to adcoelho/kibana
that referenced
this pull request
Dec 18, 2024
Connected with elastic/kibana-team#1322 ## Summary This PR migrates the remaining response-ops routes that do not use access tags. [Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit be8e298)
adcoelho
added a commit
that referenced
this pull request
Dec 19, 2024
…204769) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Connectors]Migrate remaining routes. (#204042)](#204042) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-16T11:54:49Z","message":"[ResponseOps][Connectors]Migrate remaining routes. (#204042)\n\nConnected with https://github.com/elastic/kibana-team/issues/1322\r\n\r\n## Summary\r\n\r\nThis PR migrates the remaining response-ops routes that do not use\r\naccess tags.\r\n\r\n\r\n[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"be8e29836bd805f613a25d4bc467c43a1c7a3649","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","backport missing","v9.0.0","backport:prev-minor","v8.18.0"],"number":204042,"url":"https://github.com/elastic/kibana/pull/204042","mergeCommit":{"message":"[ResponseOps][Connectors]Migrate remaining routes. (#204042)\n\nConnected with https://github.com/elastic/kibana-team/issues/1322\r\n\r\n## Summary\r\n\r\nThis PR migrates the remaining response-ops routes that do not use\r\naccess tags.\r\n\r\n\r\n[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"be8e29836bd805f613a25d4bc467c43a1c7a3649"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204042","number":204042,"mergeCommit":{"message":"[ResponseOps][Connectors]Migrate remaining routes. (#204042)\n\nConnected with https://github.com/elastic/kibana-team/issues/1322\r\n\r\n## Summary\r\n\r\nThis PR migrates the remaining response-ops routes that do not use\r\naccess tags.\r\n\r\n\r\n[Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"be8e29836bd805f613a25d4bc467c43a1c7a3649"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
Connected with elastic/kibana-team#1322 ## Summary This PR migrates the remaining response-ops routes that do not use access tags. [Documentation.](https://docs.elastic.dev/kibana-dev-docs/key-concepts/security-api-authorization#opting-out-of-authorization-for-specific-routes) --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected with https://github.com/elastic/kibana-team/issues/1322
Summary
This PR migrates the remaining response-ops routes that do not use access tags.
Documentation.