-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sustainable Kibana Architecture: Relocate script v4 #204383
Sustainable Kibana Architecture: Relocate script v4 #204383
Conversation
Pinging @elastic/kibana-core (Team:Core) |
export const findGithubLogin = async () => { | ||
const res = await safeExec('gh auth status'); | ||
// e.g. ✓ Logged in to github.com account gsoldevila (/Users/gsoldevila/.config/gh/hosts.yml) | ||
const loginLine = res.stdout | ||
.split('\n') | ||
.find((line) => line.includes('Logged in')) | ||
?.split(/\t| /) | ||
.filter(Boolean); | ||
|
||
return loginLine?.[loginLine?.findIndex((fragment) => fragment === 'account') + 1]; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is subject to break in future versions of gh
. But OK for now.
Co-authored-by: Alejandro Fernández Haro <[email protected]>
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
## Summary * Auto-detect "upstream" and "origin" remotes (instead of assuming their names). * Allow relocating modules that are already in a "sustainable" folder. * Filter out modules that are in the correct locations. * Update the list of _modules to relocate_ to show only those modules that are actually moved. --------- Co-authored-by: Alejandro Fernández Haro <[email protected]>
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary