Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Infra] Display "Add metrics" callout for all containers without metrics (#202220) #202465

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[8.x] [Infra] Display "Add metrics" callout for all containers without metrics (#202220) #202465

merged 1 commit into from
Dec 2, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@iblancof
[Infra] Display "Add metrics" callout for all containers without metr…
51e32bb 
…ics (elastic#202220)

## Summary

Closes elastic#196553.

In this PR, we removed the restriction that prevented the "Add metrics"
callout from appearing on containers that aren't Docker or Kubernetes,
even if they didn’t have metrics.

Previously, this was done to only show the callout on Docker/Kubernetes
containers with available metrics. Now, the callout will be displayed
for all containers lacking metrics, ensuring a more consistent user
experience across different container types, regardless of the
underlying technology.

|View|Before|After|
|-|-|-|
|Overview|![Screenshot 2024-11-29 at 13 35
23](https://github.com/user-attachments/assets/b3d916e6-ee2b-4f1f-8d93-90c8ae595ac1)|![Screenshot
2024-11-29 at 13 33
15](https://github.com/user-attachments/assets/23bb44cf-41bc-4274-b204-8a3c9ceecea5)|
|Metrics|![Screenshot 2024-11-29 at 13 35
30](https://github.com/user-attachments/assets/3fbfb81e-d61c-4f28-b9a4-55b8009df8e1)|![Screenshot
2024-11-29 at 13 33
09](https://github.com/user-attachments/assets/1fb48b2f-457e-4453-8758-41f3ceadf794)|

The PR also addresses an issue with the onboarding link used in the
callout, where the `url` parameter was not properly preselecting any
options.
|Before|After|
|-|-|
|![Screen Recording 2024-11-29 at 13 37
05](https://github.com/user-attachments/assets/37f04535-ba4a-428b-b988-2ac4d5c0449a)|![Screen
Recording 2024-11-29 at 13 33
26](https://github.com/user-attachments/assets/b52b5b55-a387-40c8-80cd-54aedc9acfc7)|

(cherry picked from commit 1b1c415)
@kibanamachine kibanamachine enabled auto-merge (squash) December 2, 2024 13:26
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 2, 2024
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine kibanamachine merged commit 3082d5a into elastic:8.x Dec 2, 2024
13 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB -111.0B

cc @iblancof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@iblancof iblancof

Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @iblancof