[Infra] Display "Add metrics" callout for all containers without metrics #202220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Docker and Kubernetes containers
|
/ci |
…lank-metrics-section-for-containers-detected-by-eem-but-without-integrations-data
iblancof
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
…lank-metrics-section-for-containers-detected-by-eem-but-without-integrations-data
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @iblancof |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 2, 2024
…ics (elastic#202220) ## Summary Closes elastic#196553. In this PR, we removed the restriction that prevented the "Add metrics" callout from appearing on containers that aren't Docker or Kubernetes, even if they didn’t have metrics. Previously, this was done to only show the callout on Docker/Kubernetes containers with available metrics. Now, the callout will be displayed for all containers lacking metrics, ensuring a more consistent user experience across different container types, regardless of the underlying technology. |View|Before|After| |-|-|-| |Overview||| |Metrics||| The PR also addresses an issue with the onboarding link used in the callout, where the `url` parameter was not properly preselecting any options. |Before|After| |-|-| ||| (cherry picked from commit 1b1c415)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
iblancof
deleted the
196553-inventory-infra-asset-details-shows-blank-metrics-section-for-containers-detected-by-eem-but-without-integrations-data
branch
kibanamachine
added a commit
that referenced
this pull request
Dec 2, 2024
…ers without metrics (#202220) (#202465) # Backport This will backport the following commits from `main` to `8.x`: - [[Infra] Display "Add metrics" callout for all containers without metrics (#202220)](#202220) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T13:21:32Z","message":"[Infra] Display \"Add metrics\" callout for all containers without metrics (#202220)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/196553.\r\n\r\nIn this PR, we removed the restriction that prevented the \"Add metrics\"\r\ncallout from appearing on containers that aren't Docker or Kubernetes,\r\neven if they didn’t have metrics.\r\n\r\nPreviously, this was done to only show the callout on Docker/Kubernetes\r\ncontainers with available metrics. Now, the callout will be displayed\r\nfor all containers lacking metrics, ensuring a more consistent user\r\nexperience across different container types, regardless of the\r\nunderlying technology.\r\n\r\n\r\n|View|Before|After|\r\n|-|-|-|\r\n|Overview|||\r\n|Metrics|||\r\n\r\nThe PR also addresses an issue with the onboarding link used in the\r\ncallout, where the `url` parameter was not properly preselecting any\r\noptions.\r\n|Before|After|\r\n|-|-|\r\n|||","sha":"1b1c41506b9ce6f7048ad646914023bf1c795717","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.18.0"],"title":"[Infra] Display \"Add metrics\" callout for all containers without metrics","number":202220,"url":"https://github.com/elastic/kibana/pull/202220","mergeCommit":{"message":"[Infra] Display \"Add metrics\" callout for all containers without metrics (#202220)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/196553.\r\n\r\nIn this PR, we removed the restriction that prevented the \"Add metrics\"\r\ncallout from appearing on containers that aren't Docker or Kubernetes,\r\neven if they didn’t have metrics.\r\n\r\nPreviously, this was done to only show the callout on Docker/Kubernetes\r\ncontainers with available metrics. Now, the callout will be displayed\r\nfor all containers lacking metrics, ensuring a more consistent user\r\nexperience across different container types, regardless of the\r\nunderlying technology.\r\n\r\n\r\n|View|Before|After|\r\n|-|-|-|\r\n|Overview|||\r\n|Metrics|||\r\n\r\nThe PR also addresses an issue with the onboarding link used in the\r\ncallout, where the `url` parameter was not properly preselecting any\r\noptions.\r\n|Before|After|\r\n|-|-|\r\n|||","sha":"1b1c41506b9ce6f7048ad646914023bf1c795717"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202220","number":202220,"mergeCommit":{"message":"[Infra] Display \"Add metrics\" callout for all containers without metrics (#202220)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/196553.\r\n\r\nIn this PR, we removed the restriction that prevented the \"Add metrics\"\r\ncallout from appearing on containers that aren't Docker or Kubernetes,\r\neven if they didn’t have metrics.\r\n\r\nPreviously, this was done to only show the callout on Docker/Kubernetes\r\ncontainers with available metrics. Now, the callout will be displayed\r\nfor all containers lacking metrics, ensuring a more consistent user\r\nexperience across different container types, regardless of the\r\nunderlying technology.\r\n\r\n\r\n|View|Before|After|\r\n|-|-|-|\r\n|Overview|||\r\n|Metrics|||\r\n\r\nThe PR also addresses an issue with the onboarding link used in the\r\ncallout, where the `url` parameter was not properly preselecting any\r\noptions.\r\n|Before|After|\r\n|-|-|\r\n|||","sha":"1b1c41506b9ce6f7048ad646914023bf1c795717"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…ics (elastic#202220) ## Summary Closes elastic#196553. In this PR, we removed the restriction that prevented the "Add metrics" callout from appearing on containers that aren't Docker or Kubernetes, even if they didn’t have metrics. Previously, this was done to only show the callout on Docker/Kubernetes containers with available metrics. Now, the callout will be displayed for all containers lacking metrics, ensuring a more consistent user experience across different container types, regardless of the underlying technology. |View|Before|After| |-|-|-| |Overview||| |Metrics||| The PR also addresses an issue with the onboarding link used in the callout, where the `url` parameter was not properly preselecting any options. |Before|After| |-|-| |||
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…ics (elastic#202220) ## Summary Closes elastic#196553. In this PR, we removed the restriction that prevented the "Add metrics" callout from appearing on containers that aren't Docker or Kubernetes, even if they didn’t have metrics. Previously, this was done to only show the callout on Docker/Kubernetes containers with available metrics. Now, the callout will be displayed for all containers lacking metrics, ensuring a more consistent user experience across different container types, regardless of the underlying technology. |View|Before|After| |-|-|-| |Overview||| |Metrics||| The PR also addresses an issue with the onboarding link used in the callout, where the `url` parameter was not properly preselecting any options. |Before|After| |-|-| |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #196553.
In this PR, we removed the restriction that prevented the "Add metrics" callout from appearing on containers that aren't Docker or Kubernetes, even if they didn’t have metrics.
Previously, this was done to only show the callout on Docker/Kubernetes containers with available metrics. Now, the callout will be displayed for all containers lacking metrics, ensuring a more consistent user experience across different container types, regardless of the underlying technology.
The PR also addresses an issue with the onboarding link used in the callout, where the
urlparameter was not properly preselecting any options.