-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] fix point visibility regression #202358
Merged
markov00
merged 2 commits into
elastic:main
from
markov00:2024_11_29_fix_zero_radius_point_tsvb
Dec 3, 2024
Merged
[TSVB] fix point visibility regression #202358
markov00
merged 2 commits into
elastic:main
from
markov00:2024_11_29_fix_zero_radius_point_tsvb
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
Feature:TSVB
TSVB (Time Series Visual Builder)
regression
release_note:fix
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v9.0.0
v8.16.0
backport:version
Backport to applied version labels
v8.17.0
labels
Nov 29, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
mbondyra
approved these changes
Dec 3, 2024
Starting backport for target branches: 8.16, 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 3, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`; (cherry picked from commit a7397b2)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 3, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`; (cherry picked from commit a7397b2)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 3, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`; (cherry picked from commit a7397b2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 3, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[TSVB] fix point visibility regression (#202358)](#202358) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T09:27:58Z","message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","regression","release_note:fix","Team:Visualizations","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[TSVB] fix point visibility regression","number":202358,"url":"https://github.com/elastic/kibana/pull/202358","mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202358","number":202358,"mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 3, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[TSVB] fix point visibility regression (#202358)](#202358) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T09:27:58Z","message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","regression","release_note:fix","Team:Visualizations","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[TSVB] fix point visibility regression","number":202358,"url":"https://github.com/elastic/kibana/pull/202358","mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202358","number":202358,"mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 3, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[TSVB] fix point visibility regression (#202358)](#202358) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T09:27:58Z","message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","regression","release_note:fix","Team:Visualizations","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[TSVB] fix point visibility regression","number":202358,"url":"https://github.com/elastic/kibana/pull/202358","mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202358","number":202358,"mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`;
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`;
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
Feature:TSVB
TSVB (Time Series Visual Builder)
regression
release_note:fix
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v8.16.2
v8.17.0
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #200255
The regression was caused by a breaking change introduced by elastic-charts around the
area.points.visible
style, that passed from aboolean
to a union of'always' | 'never' | 'auto'
;