Skip to content

Commit

Permalink
[TSVB] fix point visibility regression (elastic#202358)
Browse files Browse the repository at this point in the history
## Summary

fix elastic#200255

The regression was caused by a [breaking
change](elastic/elastic-charts#2525) introduced
by elastic-charts around the `area.points.visible` style, that passed
from a `boolean` to a union of `'always' | 'never' | 'auto'`;
  • Loading branch information
markov00 authored and CAWilson94 committed Dec 9, 2024
1 parent 659ad67 commit ce9a758
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const getAreaStyles = ({ points, lines, color }) => ({
radius: points.radius || 0.5,
stroke: color || DEFAULT_COLOR,
strokeWidth: points.lineWidth || 5,
visible: points.lineWidth > 0 && Boolean(points.show),
visible: points.lineWidth > 0 && Boolean(points.show) ? 'always' : 'never',
},
},
curve: lines.steps ? CurveType.CURVE_STEP_AFTER : CurveType.LINEAR,
Expand Down

0 comments on commit ce9a758

Please sign in to comment.