Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the links to Logs Explorer and Discover in the Data Set details page #201916

Merged

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Nov 27, 2024

Updates the links to Logs Explorer and Discover in the Data Set details page:

  • Removes the link from the degraded docs chart action popup
  • Update the link which is next to the field selector in the degraded docs chart to include the breakdown field when navigating to Logs Explorer or Discover

Before

Screen.Recording.2024-11-27.at.11.30.51.mov

After

Screen.Recording.2024-11-27.at.11.27.01.mov

Closes #198856

@gbamparop gbamparop requested a review from a team as a code owner November 27, 2024 09:32
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 27, 2024
@gbamparop gbamparop changed the title Remove the chart actions for navigating to Logs Explorer and add the … Updates the links to Logs Explorer and Discover in the Data Set details page Nov 27, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@gbamparop gbamparop added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Nov 27, 2024
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gbamparop gbamparop enabled auto-merge (squash) November 27, 2024 10:13
@gbamparop gbamparop merged commit b680557 into elastic:main Nov 27, 2024
15 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group4 adhoc data views should open saved search by navigation to context from embeddable

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 251.4KB 250.7KB -726.0B

@davismcphee
Copy link
Contributor

@gbamparop Was this intended to be backported to 8.x too or only available in 9.0? If it's for 8.x too, the backport label will need to be updated to backport:prev-minor.

@gbamparop gbamparop added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Nov 29, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12088301305

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12088301301

@gbamparop
Copy link
Contributor Author

@gbamparop Was this intended to be backported to 8.x too or only available in 9.0? If it's for 8.x too, the backport label will need to be updated to backport:prev-minor.

Good point, backporting to 8.x too, thanks!

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 29, 2024
…ls page (elastic#201916)

Updates the links to Logs Explorer and Discover in the Data Set details
page:
- Removes the link from the degraded docs chart action popup
- Update the link which is next to the field selector in the degraded
docs chart to include the breakdown field when navigating to Logs
Explorer or Discover

### Before

https://github.com/user-attachments/assets/3586c22e-64e5-40c3-9b5e-f729c19a6816

### After

https://github.com/user-attachments/assets/fe53b5a2-b986-4343-8773-75e97c0fbc43

Closes elastic#198856

(cherry picked from commit b680557)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 29, 2024
…ls page (elastic#201916)

Updates the links to Logs Explorer and Discover in the Data Set details
page:
- Removes the link from the degraded docs chart action popup
- Update the link which is next to the field selector in the degraded
docs chart to include the breakdown field when navigating to Logs
Explorer or Discover

### Before

https://github.com/user-attachments/assets/3586c22e-64e5-40c3-9b5e-f729c19a6816

### After

https://github.com/user-attachments/assets/fe53b5a2-b986-4343-8773-75e97c0fbc43

Closes elastic#198856

(cherry picked from commit b680557)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 29, 2024
… details page (#201916) (#202357)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Updates the links to Logs Explorer and Discover in the Data Set
details page (#201916)](#201916)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Giorgos
Bamparopoulos","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T11:25:01Z","message":"Updates
the links to Logs Explorer and Discover in the Data Set details page
(#201916)\n\nUpdates the links to Logs Explorer and Discover in the Data
Set details\r\npage:\r\n- Removes the link from the degraded docs chart
action popup\r\n- Update the link which is next to the field selector in
the degraded\r\ndocs chart to include the breakdown field when
navigating to Logs\r\nExplorer or Discover\r\n\r\n###
Before\r\n\r\nhttps://github.com/user-attachments/assets/3586c22e-64e5-40c3-9b5e-f729c19a6816\r\n\r\n###
After\r\n\r\nhttps://github.com/user-attachments/assets/fe53b5a2-b986-4343-8773-75e97c0fbc43\r\n\r\nCloses
https://github.com/elastic/kibana/issues/198856","sha":"b680557836fc2a255eeb7ec3efa7ee2e4f86a99a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"Updates
the links to Logs Explorer and Discover in the Data Set details
page","number":201916,"url":"https://github.com/elastic/kibana/pull/201916","mergeCommit":{"message":"Updates
the links to Logs Explorer and Discover in the Data Set details page
(#201916)\n\nUpdates the links to Logs Explorer and Discover in the Data
Set details\r\npage:\r\n- Removes the link from the degraded docs chart
action popup\r\n- Update the link which is next to the field selector in
the degraded\r\ndocs chart to include the breakdown field when
navigating to Logs\r\nExplorer or Discover\r\n\r\n###
Before\r\n\r\nhttps://github.com/user-attachments/assets/3586c22e-64e5-40c3-9b5e-f729c19a6816\r\n\r\n###
After\r\n\r\nhttps://github.com/user-attachments/assets/fe53b5a2-b986-4343-8773-75e97c0fbc43\r\n\r\nCloses
https://github.com/elastic/kibana/issues/198856","sha":"b680557836fc2a255eeb7ec3efa7ee2e4f86a99a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201916","number":201916,"mergeCommit":{"message":"Updates
the links to Logs Explorer and Discover in the Data Set details page
(#201916)\n\nUpdates the links to Logs Explorer and Discover in the Data
Set details\r\npage:\r\n- Removes the link from the degraded docs chart
action popup\r\n- Update the link which is next to the field selector in
the degraded\r\ndocs chart to include the breakdown field when
navigating to Logs\r\nExplorer or Discover\r\n\r\n###
Before\r\n\r\nhttps://github.com/user-attachments/assets/3586c22e-64e5-40c3-9b5e-f729c19a6816\r\n\r\n###
After\r\n\r\nhttps://github.com/user-attachments/assets/fe53b5a2-b986-4343-8773-75e97c0fbc43\r\n\r\nCloses
https://github.com/elastic/kibana/issues/198856","sha":"b680557836fc2a255eeb7ec3efa7ee2e4f86a99a"}}]}]
BACKPORT-->

Co-authored-by: Giorgos Bamparopoulos <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…ls page (elastic#201916)

Updates the links to Logs Explorer and Discover in the Data Set details
page:
- Removes the link from the degraded docs chart action popup
- Update the link which is next to the field selector in the degraded
docs chart to include the breakdown field when navigating to Logs
Explorer or Discover

### Before

https://github.com/user-attachments/assets/3586c22e-64e5-40c3-9b5e-f729c19a6816

### After

https://github.com/user-attachments/assets/fe53b5a2-b986-4343-8773-75e97c0fbc43

Closes elastic#198856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
5 participants