Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Lens] rewrite BucketNestingEditor tests to use react testing library (#199888) #201529

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[8.x] [Lens] rewrite BucketNestingEditor tests to use react testing library (#199888) #201529

merged 2 commits into from
Nov 26, 2024

Conversation

mbondyra
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@kyracho
[Lens] rewrite BucketNestingEditor tests to use react testing library (…
42f5cdf 
…elastic#199888)

## Summary

Hi! This PR rewrites the `BucketNestingEditor` tests to use the react
testing library.

Fixes elastic#199839

<img width="1063" alt="Screenshot 2024-11-12 at 3 35 06 PM"
src="https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1">

### Checklist

- [n/a] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Marta Bondyra <[email protected]>
(cherry picked from commit eddfe5b)
@mbondyra mbondyra enabled auto-merge (squash) November 25, 2024 09:37
@mbondyra mbondyra mentioned this pull request Nov 25, 2024
Merged
@mbondyra mbondyra disabled auto-merge November 25, 2024 09:38
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@mbondyra mbondyra enabled auto-merge (squash) November 25, 2024 15:25
@mbondyra mbondyra merged commit 4a48ec8 into elastic:8.x Nov 26, 2024
20 checks passed
@mbondyra mbondyra deleted the backport/8.x/pr-199888 branch November 26, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbondyra @elasticmachine @markov00 @kyracho